[issue20123] pydoc.synopsis fails to load binary modules

Irit Katriel added the comment: Re-enabling the test is tracked on 20128, so this issue is no longer needed. -- nosy: +iritkatriel resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue20123] pydoc.synopsis fails to load binary modules

Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20123] pydoc.synopsis fails to load binary modules

Gregory P. Smith added the comment: fyi - tracking the new issue koobs reported in http://bugs.python.org/issue22910 -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123

[issue20123] pydoc.synopsis fails to load binary modules

koobs added the comment: koobs-freebsd9 (3.4) buildbot has also been failing for a while on what seems to be this changeset: == ERROR: test_synopsis_sourceless (test.test_pydoc.PydocDocTest)

[issue20123] pydoc.synopsis fails to load binary modules

Changes by koobs koobs.free...@gmail.com: -- nosy: +koobs ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123 ___ ___ Python-bugs-list mailing

[issue20123] pydoc.synopsis fails to load binary modules

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123 ___

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: I realized today that this should probably be fixed in 3.3 as well, as RDM implied by marking it as also a 3.3 bug. :) -- resolution: fixed - stage: committed/rejected - patch review status: closed - open versions: -Python 3.4

[issue20123] pydoc.synopsis fails to load binary modules

New submission from Eric Snow: I'm guessing this is a very seldom (never?) used code path. I've included a patch to test and fix the problem. The patch includes several related tests for pydoc. $ py3 -c 'import pydoc;

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: FYI, I found this while working on issue #19703. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123 ___ ___

[issue20123] pydoc.synopsis fails to load binary modules

Larry Hastings added the comment: Well please get a second opinion. I don't know why you added me, I'm not qualified. -- nosy: +brett.cannon, ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: Not sure why I nosy'ed you, either. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123 ___ ___

[issue20123] pydoc.synopsis fails to load binary modules

R. David Murray added the comment: In 2.7 the code just does an open. Victor changed it to call tokenize.open in 3.2, but tokenize.open obviously only works on python source files. So the logic of that method is now completely wrong. I'm not sure the logic made a lot of sense even

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: Thanks for taking a look. Here's the patch that I totally forget to attach. -- keywords: +patch Added file: http://bugs.python.org/file33311/issue20123-fix-pydoc-synopsis.diff ___ Python tracker rep...@bugs.python.org

[issue20123] pydoc.synopsis fails to load binary modules

R. David Murray added the comment: Is it the case that given a filename, it might be possible to load a module even if open(filename) fails? I think the logic is clearer in the form where it is not pulled out into a separate helper function. You can avoid the double check on the extension by

[issue20123] pydoc.synopsis fails to load binary modules

Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file33311/issue20123-fix-pydoc-synopsis.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123 ___

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: Sounds good to me. Here's an updated patch. -- Added file: http://bugs.python.org/file33312/issue20123-fix-pydoc-synopsis.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123

[issue20123] pydoc.synopsis fails to load binary modules

R. David Murray added the comment: Looks good, except you can replace those any calls with simple calls to endswith using a tuple of strings (I forgot the call to tuple in my example). -- ___ Python tracker rep...@bugs.python.org

[issue20123] pydoc.synopsis fails to load binary modules

Roundup Robot added the comment: New changeset d6c3fb8d5f84 by Eric Snow in branch 'default': Issue 20123: Fix pydoc.synopsis() for binary modules. http://hg.python.org/cpython/rev/d6c3fb8d5f84 -- nosy: +python-dev ___ Python tracker

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: Ah, I missed that in your earlier suggestion. I followed your recommendation. Thanks for that. :) -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: This broke one of the FreeBSD buildbots: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/6102 -- status: closed - open ___ Python tracker rep...@bugs.python.org

[issue20123] pydoc.synopsis fails to load binary modules

Roundup Robot added the comment: New changeset ff3be21338d5 by Eric Snow in branch 'default': Issue 20123: try using a different builtin module in a pydoc test. http://hg.python.org/cpython/rev/ff3be21338d5 -- ___ Python tracker

[issue20123] pydoc.synopsis fails to load binary modules

Roundup Robot added the comment: New changeset efcf163d04f5 by Eric Snow in branch 'default': Issue 20123: Disable a problematic test. http://hg.python.org/cpython/rev/efcf163d04f5 -- ___ Python tracker rep...@bugs.python.org

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: I've run out of time to trouble-shoot the failure (specific to 1 buildbot). Until I can get back to it, I've disabled the problematic test (even though it's only a problem on 1 buildbot). -- ___ Python tracker

[issue20123] pydoc.synopsis fails to load binary modules

Eric Snow added the comment: The buildbot is happy again. I'll address fixing that test in issue #20128. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123 ___

[issue20123] pydoc.synopsis fails to load binary modules

Larry Hastings added the comment: Thanks for seeing this through, Eric. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20123 ___ ___