Roundup Robot added the comment:
New changeset d4099b8a7d0f by Serhiy Storchaka in branch 'default':
Issue #20133: The audioop module now uses Argument Clinic.
http://hg.python.org/cpython/rev/d4099b8a7d0f
--
nosy: +python-dev
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
Larry Hastings added the comment:
Christian Heimes just posted this to python-dev:
Coverity has detected an issue in this commit:
** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO)
/Modules/audioop.c: 1375 in
Serhiy Storchaka added the comment:
Christian Heimes just posted this to python-dev:
See issue20394. This is unrelated to clicalization patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file33320/audioop_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file33352/audioop_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file33461/audioop_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file33530/audioop_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
___
Serhiy Storchaka added the comment:
I mean I want to add support for float32 and float64 in audioop functions. In
that case return value of getsample(), max(), ets will be no longer integer for
float format.
--
___
Python tracker
Larry Hastings added the comment:
I don't understand. Python already has double which is float64. Why would
Python need a second floating-point type which isn't as good?
In any case, if somehow you get float32 in, we could just change the return
converters then. So I would still prefer
Serhiy Storchaka added the comment:
Patch updated to tip (a little different generated code for Py_buffer).
I don't want to use return converters here because I want to add support for
float32 and float64 in 3.5.
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file33461/audioop_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
___
Larry Hastings added the comment:
Can you refresh the patch? I think all the problems you cited are fixed, and
also the comments Argument Clinic uses were all changed. I'll review when you
have a fresh patch.
--
title: Convert the audioop module to use Argument Clinic - Derby:
Serhiy Storchaka added the comment:
Here is refreshed patch.
--
Added file: http://bugs.python.org/file33352/audioop_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
___
Larry Hastings added the comment:
Serhiy: Assigning to you because you wrote a patch; if you don't want the
issue, sorry, please undo it.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
15 matches
Mail list logo
