R. David Murray added the comment:
Terry: the slowdown might be IPV6 handling, which was a bit broken on windows.
In any case, I think the slowdown should be treated as a separate issue if you
care about it, so I'm going to close this. (I think it would be great if
someone would do a review
Roundup Robot added the comment:
New changeset 3ffa43e8ab47 by Terry Jan Reedy in branch '2.7':
Issue #20155: Fix non-buildbot test failure on Windows. Patch by Claudiu Popa,
https://hg.python.org/cpython/rev/3ffa43e8ab47
New changeset 5c0f17063fb8 by Terry Jan Reedy in branch '3.4':
Issue
Terry J. Reedy added the comment:
Patch fixes failures for me. Let's hope that change does not fail on other
systems or buildbots (starting at 21:17 bb time). I will check bbs later.
There seems to be a 2.7 speed issue which looks like a hang until running with
-v. On my machine, 2.7 runs
Terry J. Reedy added the comment:
I copied the example profile code at the top and bottom of test_get and nearly
all (7.155 / 7.210) of the time is in _socket.socket.connect, which takes .5
sec per call.
147.1550.5117.1550.511 {method 'connect' of _socket.socket'
objects}
I
Terry J. Reedy added the comment:
If Python itself works correctly on a machine, it is a bug for a test to say
that is it not, by failing. Should we change
-response = self.request('/', method='get')
to
+response = self.request('/', method='gets')
or
+response =
R. David Murray added the comment:
It should be 'custom', since that will actually test case sensitivity, which
'gets' would not.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20155
___
R. David Murray added the comment:
If deactivating the AV/firewall doesn't change the behavior, it is presumably a
different problem. But let's see what Claudiu has to say, since he was able to
reproduce and then circumvent the original problem.
--
Claudiu Popa added the comment:
Terry is right, this patch doesn't completely work. But with this fix the
problem is solved:
diff -r 394e6bda5a70 Lib/test/test_httpservers.py
--- a/Lib/test/test_httpservers.py Sun Jun 29 15:56:21 2014 +0300
+++ b/Lib/test/test_httpservers.py Sun Jun
Claudiu Popa added the comment:
Although it is incorrect, because the test specifically tests case sensitivity.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20155
___
R. David Murray added the comment:
What if you use 'custom' instead?
--
resolution: fixed -
stage: resolved - needs patch
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20155
Claudiu Popa added the comment:
It works with 'custom'.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20155
___
___
Python-bugs-list mailing
Terry J. Reedy added the comment:
Both 'gets' and 'custom' work on my machine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20155
___
___
Jeff Allen added the comment:
Disabling the AV/firewall did not stop the symptoms when I was investigating
originally. In order to get the unmodified test to pass, I had to stop the BFE
(base filtering engine), which I think may have been given new rules or
behaviours as a result of
Terry J. Reedy added the comment:
After updating and rebuilding (32 bit VC express, on 64 bit Win 7), I get the
same error as in msg210926, with or without -uall, even after turning my
antivirus off.
File F:\Python\dev\4\py34\lib\test\test_httpservers.py, line 310, in
test_invalid_requests
Claudiu Popa added the comment:
It would be nice if this could be committed. It's cumbersome to always have to
deactivate the AV solution when running the tests on Windows, in order to avoid
a failure of test_httpservers.
--
___
Python tracker
Roundup Robot added the comment:
New changeset ffdd2d0b0049 by R David Murray in branch '3.4':
#20155: use fake HTTP method names so windows doesn't hang the tests.
http://hg.python.org/cpython/rev/ffdd2d0b0049
New changeset e67ad57eed26 by R David Murray in branch 'default':
merge: #20155: use
R. David Murray added the comment:
Done. Thanks Jeff.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20155
___
Jeff Allen added the comment:
I worked out that the essence of the test is to insert an extra \n at the end
of a GET request line. The request is syntactically invalid for HTTP. The
\n\r\n appears like two blank lines, implying no headers, but the headers then
follow where no data should be.
R. David Murray added the comment:
Ah, OK. I was thinking that BaseHTTPRequestHandler defined GET, but I see that
it doesn't.
So yes, this patch looks fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20155
R. David Murray added the comment:
The second test looks correct to me. I don't understand what
tset_request_line_trimming is testing (I haven't investigated), so I don't know
if that one is correct, but it is certainly plausible.
--
___
Python
Claudiu.Popa added the comment:
Terry, I had the same problem with that failing
test_httpservers.test_invalid_request using the latest build on Windows.
After debugging, I found out that the problem was caused by my antivirus
solution. Its http scanning engine caught malformed http requests,
Jeff Allen added the comment:
Thanks for adding to the evidence here. As discussed above, disabling the
security product (which is Bitdefender) on my PC didn't stop the problem for
me, and I'm reluctant to uninstall. I narrowed it to the Windows Base Filtering
Engine, but perhaps the
Terry J. Reedy added the comment:
Except where specifically indicated otherwise, the Python test suite should be
the same, and correct, for all implementations. If that change is correct for
Jython, it should be correct for CPython.
David, Ezio, or Senthil: does the change in the Jython patch
Jeff Allen added the comment:
Actual patch for your convenience. I'm not set up to build CPython from source,
so I've tested this with my installed CPython 2.7.6, and it's clean.
[As for keeping the tests in sync, yes that's our aim. Jython's Lib contains
only the customised versions, and
Terry J. Reedy added the comment:
Installed 3.4.0c1 on Windows:
test test_httpservers failed -- Traceback (most recent call last):
File C:\Programs\Python34.32\lib\test\test_httpservers.py, line 309, in
test_invalid_requests
self.check_status_and_reason(response, 501)
File
New submission from Jeff Allen:
When I run:
start python -m test.test_httpservers
test_request_line_trimming reports ERROR, and the test hangs at
test_version_none. If I run a copy of the test in which the latter test is
skipped with @unittest.skipIf(sys.platform == win32, ...), the error
26 matches
Mail list logo
