[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: New changeset 9650fe0197779b4dfded94be111e39c5810f098f by Zackery Spytz in branch 'master': bpo-20179: Convert the _overlapped module to the Argument Clinic (GH-14275) https://github.com/python/cpython/commit/9650fe0197779b4dfded94be111e39c5810f098f

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Zackery Spytz added the comment: PR 14275 converts Modules/overlapped.c. Many methods now use METH_FASTCALL. -- nosy: +ZackerySpytz ___ Python tracker ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Change by Zackery Spytz : -- pull_requests: +14099 pull_request: https://github.com/python/cpython/pull/14275 ___ Python tracker ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Tal Einat added the comment: Can someone clarify whether Modules/overlapped.c should be converted to use AC? -- ___ Python tracker ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Antoine Pitrou added the comment: I can propose three remedies: A) back out the Clinic conversion in _ssl.c B) support Clinic in 2.7 just for _ssl.c C) do a one-time backport of the Clinic generated code for _ssl.c I'd rather have A or C than B. By the way, this discussion seems to focus

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: Clinic's syntax is diverging from what shipped with 3.4. So if you copied _ssl.c over, it wouldn't work with the Clinic that shipped with 3.4. Maybe the best thing is if Clinic in trunk supports legacy mode, where the code it generates is compatible with

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Antoine Pitrou added the comment: Le 03/05/2015 23:06, Larry Hastings a écrit : Larry Hastings added the comment: We discussed it in IRC a bit (and I got a little education). Can we have a transcript somewhere? -- ___ Python tracker

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: We discussed it in IRC a bit (and I got a little education). I can propose three remedies: A) back out the Clinic conversion in _ssl.c B) support Clinic in 2.7 just for _ssl.c C) do a one-time backport of the Clinic generated code for _ssl.c IMO these are in

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: Attached. Glad you asked right away, it would have been a lot harder to get later! -- Added file: http://bugs.python.org/file39283/irc.transcript.of._ssl.clinic.discussion.txt ___ Python tracker

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Antoine Pitrou added the comment: Thank you! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___ ___ Python-bugs-list mailing list

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Antoine Pitrou added the comment: I have no opinion on whether this is a good thing or not. Security backports should be few and far between, so I don't think it's a big problem if they are a bit more difficult. -- ___ Python tracker

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Christian Heimes added the comment: I'm with Alex. The move to argument clinic is going to make it very hard to port patches to older versions of Python, especially Python 2.7. -- ___ Python tracker rep...@bugs.python.org

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: Sorry. Should I rollback 1eaaf27b3956? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___ ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Roundup Robot added the comment: New changeset 1eaaf27b3956 by Serhiy Storchaka in branch 'default': Issue #20179: Converted the _ssl module to Argument Clinic. https://hg.python.org/cpython/rev/1eaaf27b3956 -- ___ Python tracker

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: How often are patches backported to 2.7? While I understand the sentiment, I'd like to understand the scale of the objection being raised. I suspect it's infrequent, making the objection a minor one. -- ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Christian Heimes added the comment: You are right, patches are seldomly backported to Python 2.7. Features are never backported. Well, except for one exception: the ssl module. :) -- ___ Python tracker rep...@bugs.python.org

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Donald Stufft added the comment: I think it's worthwhile to maintain the ability to easily backport patches from 3.x to 2.7, especially given the security sensitive nature of the ssl module. -- ___ Python tracker rep...@bugs.python.org

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: The patch updated to the tip. -- Added file: http://bugs.python.org/file39072/ssl_clinic_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Alex Gaynor added the comment: I'm concerned the _ssl changes will make security backports significantly more difficult. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: _ssl.enum_certificates() and _ssl.enum_crls() is not converted because their parsing code look incorrect (issue23875). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: Proposed patch converts the _ssl module to Argument Clinic. Total 39 methods converted. -- keywords: +needs review nosy: +alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou, serhiy.storchaka stage: needs patch - patch review Added

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Argument Clinic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___ ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: All the Derby patches should only go into trunk at this point. -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Roundup Robot added the comment: New changeset 4d3d0659b55e by Martin v. Löwis in branch 'default': Issue #20179: Apply Argument Clinic to bytes and bytearray. http://hg.python.org/cpython/rev/4d3d0659b55e -- nosy: +python-dev ___ Python tracker

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Martin v. Löwis added the comment: Tal: Thanks for the patch. I applied it with updates to the current Argument Clinic. _ssl and _overlapped are still to be done. -- nosy: +loewis ___ Python tracker rep...@bugs.python.org

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Tal Einat added the comment: Attached patch for AC conversion of Objects/bytesobject.c and Objects/bytearrayobject.c. This is one patch because there are changes that must be done in bytes_methods.h and bytes_methods.c that affect both of bytesobject.c and bytearrayobject.c. Those changes

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Tal Einat added the comment: Attached updated patch for bytes and bytearray. In the previous patch I missed the 'clear' and 'copy' bytearray methods. This patch is a replacement for the previous one, with the additional conversion of these two methods. -- Added file:

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Tal Einat added the comment: While converting Objects/stringlib/transmogrify.h as part of issue20180 (Derby #11), some changes to Objects/bytesobject.c and Objects/bytearrayobject.c were required. Those changes are included in the relevant patch attached to that issue. -- nosy:

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

New submission from Larry Hastings: This issue is part of the Great Argument Clinic Conversion Derby, where we're trying to convert as much of Python 3.4 to use Argument Clinic as we can before Release Candidate 1 on January 19. This issue asks you to change the following bundle of files: