[issue20223] inspect.signature does not support new functools.partialmethod

[Yury Selivanov]

Yury Selivanov added the comment:

Thanks for the review, Nick.
Closing the issue now.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Roundup Robot]

Roundup Robot added the comment:

New changeset baedc256999a by Yury Selivanov in branch 'default':
inspect.signature: Add support for 'functools.partialmethod' #20223
http://hg.python.org/cpython/rev/baedc256999a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Larry Hastings]

Larry Hastings added the comment:

The patch from #20189 has landed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Nick Coghlan]

Nick Coghlan added the comment:

As far as pushing goes, I'd wait until Larry lands issue 20189 - I suspect 
there's a risk of conflict between these patches in the inspect module, and 
that one is key to getting builtin signatures supported properly :)

--
dependencies: +inspect.Signature doesn't recognize all builtin types

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Nick Coghlan]

Nick Coghlan added the comment:

Yury, I believe the review comments from Rietveld go to the address you have 
registered as primary in the tracker, so that's currently your address with the 
".ml" suffix rather than your main one.

My only suggestion was to use ._partialmethod for the attribute name, rather 
than __partialmethod__, since this feels a bit more like an ordinary private 
attribute, rather than a new protocol. Lots of introspection tools deliberately 
*display* dunder names, and that doesn't really feel appropriate here.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Yury Selivanov]

Yury Selivanov added the comment:

> I'm not sure why you're asking Nick.  Is he the release manager for 3.4?

I'm asking him because he wrote "Reviewing the patch now.", and I thought that 
he might have actually seen the patch already.

I'm more than fine if anyone else reviews the patch, really.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Larry Hastings]

Larry Hastings added the comment:

I'm not sure why you're asking Nick.  Is he the release manager for 3.4?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Yury Selivanov]

Yury Selivanov added the comment:

> Reviewing the patch now.

Nick, can I push this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Nick Coghlan]

Nick Coghlan added the comment:

Aye, I agree with Terry that this is a behavioural bug introduced with the new 
partialmethod feature - we missed adding a new test case to check that 
inspect.signature handled it properly.

Reviewing the patch now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Terry J. Reedy]

Terry J. Reedy added the comment:

This strikes me as a bug introduced with the new 3.4 feature and thus a Type: 
behavior issue eligible for 3.4. inspect.signature should work correctly with 
any python-coded callable and not return a wrong answer. (And we are trying to 
get inspect to work with C-coded callables also in 3.4.)

--
nosy: +terry.reedy
type: enhancement -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20223] inspect.signature does not support new functools.partialmethod

[Yury Selivanov]

New submission from Yury Selivanov:

new and handy functools.partialmethod doesn't fully support inspect.signature.

For instance, for the following code:

class Spam:
def say(self, a, b=1):
print(a)
hello = functools.partialmethod(say, 'hello')

the 'signature(Spam.hello)' will always return '(*args, **keywords)'

I'm attaching a patch that fixes that, so the signature for the above example 
will be '(self, b=1)'.

--
components: Library (Lib)
files: signature_partialmeth_01.patch
keywords: patch
messages: 207915
nosy: brett.cannon, larry, ncoghlan, yselivanov
priority: normal
severity: normal
status: open
title: inspect.signature does not support new functools.partialmethod
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file33418/signature_partialmeth_01.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com