[issue20262] Convert some debugging prints in zipfile to warnings

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Roundup Robot]

Roundup Robot added the comment:

New changeset 208fa45672c2 by Serhiy Storchaka in branch '2.7':
Issue #20262: Warnings are raised now when duplicate names are added in the
http://hg.python.org/cpython/rev/208fa45672c2

New changeset 9fda6658c01a by Serhiy Storchaka in branch '3.3':
Issue #20262: Warnings are raised now when duplicate names are added in the
http://hg.python.org/cpython/rev/9fda6658c01a

New changeset f7cebf727bc6 by Serhiy Storchaka in branch 'default':
Issue #20262: Warnings are raised now when duplicate names are added in the
http://hg.python.org/cpython/rev/f7cebf727bc6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Benjamin just have approved it for 2.7.

--
assignee:  -> serhiy.storchaka
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Well, then I should only ask Benjamin.

--
nosy: +benjamin.peterson
versions: +Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Larry Hastings]

Larry Hastings added the comment:

I will bow to the wisdom of my predecessor and accept this patch for beta 3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Georg Brandl]

Georg Brandl added the comment:

I'm actually more on the "fixing a bug" side.  For me this is fine for 3.3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I'm not sure. This is why I had added Larry and Georg to nosy list. This issue 
looks in a half-way between fixing a bug and adding new feature.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Meador Inge]

Meador Inge added the comment:

LGTM.

I audited the other 'ZipFile.debug' uses and agree that the others are
mainly useful in debugging the zipfile implementation itself.

Since it isn't that critical of a change, the default branch should be
sufficient.

--
nosy: +meador.inge
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20262] Convert some debugging prints in zipfile to warnings

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

When ZipFile.debug is not zero, some debugging messages are printed to stdout. 
Some of them are for debugging the zipfile module itself. But some are warnings 
about user's operation which perhaps make not what the user is expected -- 
truncating long archive comment or adding a file with duplicated name. These 
cases cases can be considered as logic error, they can be prevented by external 
checks (check that comment's length does not excite the limit and that 
specified name is not in the ZIP file). So it will be sane and helpful to 
convert these prints to regular warnings, which are controlled in same way as 
all other warnings.

See also issue2824. It have a patch which looks too excessive to me.

Here is a patch. I don't sure to which version it should be targeted.

--
components: Library (Lib)
files: zipfile_warnings.patch
keywords: patch
messages: 208112
nosy: alanmcintyre, georg.brandl, larry, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Convert some debugging prints in zipfile to warnings
Added file: http://bugs.python.org/file33468/zipfile_warnings.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com