Roundup Robot added the comment:
New changeset 71b9a841119a by R David Murray in branch 'default':
#20295: Teach imghdr to recognize OpenEXR format images.
http://hg.python.org/cpython/rev/71b9a841119a
--
nosy: +python-dev
___
Python tracker
R. David Murray added the comment:
Thanks, Martin and Claudiu.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20295
Changes by Claudiu Popa pcmantic...@gmail.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20295
___
___
Claudiu Popa added the comment:
This seems commit ready.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20295
___
Claudiu Popa added the comment:
Here's an updated patch with a small exr test file.
--
Added file: http://bugs.python.org/file35692/issue20295.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20295
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20295
___
___
Martin Vignali added the comment:
New patch with formatting correction and documentation update.
I'm not sure about the place of the versionadded directive in the documentation.
--
Added file: http://bugs.python.org/file33547/img_hdr_exr_2.patch
___
SilentGhost added the comment:
Martin, it would be better if you do the check the way it's done in test_rast:
h.startswith(b'\x76\x2f\x31\x01')
Otherwise, you need to check that that h has at least 4 elements (if it doesn't
you'll get an IndexError).
--
nosy: +SilentGhost
Martin Vignali added the comment:
You're right, i make the correction, in a new patch.
I make other tests, with official sample files :
http://download.savannah.nongnu.org/releases/openexr/openexr-images-1.4.0.tar.gz
--
Added file: http://bugs.python.org/file33554/img_hdr_exr_3.patch
Claudiu.Popa added the comment:
Hi, Martin.
Please see issue19990, which tries to add unit tests for imghdr module. It
would be nice if you could expand on it with an exr file, for your use case.
--
nosy: +Claudiu.Popa
___
Python tracker
New submission from Martin Vignali:
Add support for detect openexr file (http://www.openexr.com/)
Based on information provided by :
http://www.openexr.com/ReadingAndWritingImageFiles.pdf
I make some tests, on different kind of exr file, to check, the new function.
--
components:
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
stage: - patch review
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20295
___
12 matches
Mail list logo