Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20520
___
Serhiy Storchaka added the comment:
Aha! It looks as a bug in UTF-7 codec.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20520
___
___
Vajrasky Kok added the comment:
The culprit:
diff -r b4e99bec0c8a Lib/test/test_codecs.py
--- a/Lib/test/test_codecs.py Fri Feb 07 10:10:55 2014 +0200
+++ b/Lib/test/test_codecs.py Fri Feb 07 17:14:12 2014 +0800
@@ -164,6 +164,8 @@
s = 10*(size*a + lineend + xxx\n)
Serhiy Storchaka added the comment:
Opened separate issue20538 for this bug.
--
dependencies: +Segfault in UTF-7 incremental decoder
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20520
___
Serhiy Storchaka added the comment:
Thank you Vajrasky. I got the same result.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20520
___
___
Ned Deily added the comment:
The change has broken the builds, for example,
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/1197.
[ 29/389] test_codecs
Assertion failed: (maxchar = 0x100), function _PyUnicode_CheckConsistency,
file Objects/unicodeobject.c, line 410.
New submission from Serhiy Storchaka:
The ReadTest.test_readline test in Lib/test/test_codecs.py has two loops on \n
\r\n \r \u2028.split(). But as far as \n \r\n \r \u2028.split() is empty
list (because newline characters are whitespace characters), the bodies of
these loops are never
Walter Dörwald added the comment:
\n \r\n \r \u2028.split() should have been \n \r\n \r \u2028.split( ),
i.e. a list of different line ends.
The purpose of these tests is not entirely clear, so I'm not sure that it is
properly grasped the idea of the author.
I wrote the tests nearly 10
Serhiy Storchaka added the comment:
\n \r\n \r \u2028.split() should have been \n \r\n \r \u2028.split( ),
i.e. a list of different line ends.
Yes, this is obvious fix, but explicit tuple of line ends looks more clear and
error-proof to me.
--
Walter Dörwald added the comment:
True, here's an updated patch.
--
Added file: http://bugs.python.org/file33933/fix_linetests2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20520
___
Roundup Robot added the comment:
New changeset 305b6a5da852 by Serhiy Storchaka in branch '2.7':
Issue #20520: Fixed readline test in test_codecs.
http://hg.python.org/cpython/rev/305b6a5da852
New changeset 82d374a9bbc7 by Serhiy Storchaka in branch '3.3':
Issue #20520: Fixed readline test in
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20520
12 matches
Mail list logo