[issue20557] Use specific asserts in io tests

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20557] Use specific asserts in io tests

[Roundup Robot]

Roundup Robot added the comment:

New changeset ace74c445a3f by Serhiy Storchaka in branch '3.4':
Issue #20557: Use specific asserts in io tests.
https://hg.python.org/cpython/rev/ace74c445a3f

New changeset 2453ac990e5b by Serhiy Storchaka in branch '3.5':
Issue #20557: Use specific asserts in io tests.
https://hg.python.org/cpython/rev/2453ac990e5b

New changeset 859a45ca1e86 by Serhiy Storchaka in branch 'default':
Issue #20557: Use specific asserts in io tests.
https://hg.python.org/cpython/rev/859a45ca1e86

New changeset 68115dd0c7f5 by Serhiy Storchaka in branch '2.7':
Issue #20557: Use specific asserts in io tests.
https://hg.python.org/cpython/rev/68115dd0c7f5

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20557] Use specific asserts in io tests

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Actually Raymond objected. But under pressure of positive feedbacks and to 
avoid non-polite discussion I'll commit the patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20557] Use specific asserts in io tests

[Antoine Pitrou]

Antoine Pitrou added the comment:

+1

--
versions: +Python 3.5, Python 3.6 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20557] Use specific asserts in io tests

[Robert Collins]

Robert Collins added the comment:

@serhiy I think you should apply this: you're a committer, and no committers 
have objected in over a year.

--
nosy: +rbcollins

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20557] Use specific asserts in io tests

[Demian Brecht]

Demian Brecht added the comment:

LGTM

--
nosy: +demian.brecht
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20557] Use specific asserts in io tests

[Mark Lawrence]

Mark Lawrence added the comment:

LGTM.

--
nosy: +BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20557] Use specific asserts in io tests

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

The proposed patch makes the io module tests use more specific asserts. This 
will provide more useful failure report.

--
components: Tests
files: test_io_asserts.patch
keywords: patch
messages: 210563
nosy: benjamin.peterson, hynek, pitrou, serhiy.storchaka, stutzbach
priority: normal
severity: normal
stage: patch review
status: open
title: Use specific asserts in io tests
type: enhancement
versions: Python 2.7, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file33982/test_io_asserts.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com