[issue20640] Idle: test configHelpSourceEdit

[Martin Panter]

Martin Panter added the comment:

Yep all four buildbots, x86 Tiger and AMD64 Snow Leop, 3.5 and 3.x, are now 
green.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Terry J. Reedy]

Terry J. Reedy added the comment:

Patch should fix test for this issue.  Please retest and close if it does.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Roundup Robot]

Roundup Robot added the comment:

New changeset ada719145597 by Terry Jan Reedy in branch '3.5':
Issue #20640: Add https: to url prefixes so test passes on Darwin.
https://hg.python.org/cpython/rev/ada719145597

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

For test_idlever see issue25747.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Martin Panter]

Martin Panter added the comment:

FYI this broke the OS X buildbots:

==
FAIL: test_ok (idlelib.idle_test.test_config_help.ConfigHelpTest)
--
Traceback (most recent call last):
  File 
"/Users/db3l/buildarea/3.5.bolen-tiger/build/Lib/idlelib/idle_test/test_config_help.py",
 line 96, in test_ok
'https://docs.python.org'))
AssertionError: ['help', 'file://https://docs.python.org'] != ('help', 
'https://docs.python.org')

==
FAIL: test_idlever (idlelib.idle_test.test_warning.ImportWarnTest)
--
Traceback (most recent call last):
  File 
"/Users/db3l/buildarea/3.5.bolen-tiger/build/Lib/idlelib/idle_test/test_warning.py",
 line 76, in test_idlever
self.assertEqual(len(w), 1)
AssertionError: 0 != 1

(I’m partly to blame for the current 3.x OS X breakage, but not 3.5.)

--
nosy: +martin.panter
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Terry J. Reedy]

Terry J. Reedy added the comment:

The glitch with the section name was that the second time the name was pulled 
from the StringVar, it was not stripped.  The possible fixes were to strip 
after the second get, get once in ok(), strip, and pass to name_ok, or get once 
in name_ok, strip, and return to ok().  Both the latter two simplify the code a 
bit.

For help-source, the second gets were alreads stripped as well, so the glitch 
is not present.  I applied the patch as posted.  If I were to make a change to 
get once, I would do it in ok rather than in xyz_ok.  Maybe when I combine the 
files.

--
assignee:  -> terry.reedy
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6 -Python 2.7, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Roundup Robot]

Roundup Robot added the comment:

New changeset c05689e630d3 by Terry Jan Reedy in branch '3.5':
Issue #20640: Add tests for idlelib.configHelpSourceEdit.
https://hg.python.org/cpython/rev/c05689e630d3

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Saimadhav Heblikar]

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com:


Removed file: http://bugs.python.org/file34125/test-config-helpsource-33.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20640
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Saimadhav Heblikar]

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com:


Removed file: http://bugs.python.org/file34128/test-config-helpsource-27.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20640
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Saimadhav Heblikar]

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com:


Added file: http://bugs.python.org/file35446/test-cfg-help-34.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20640
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Saimadhav Heblikar]

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com:


Added file: http://bugs.python.org/file35447/test-cfg-help-27.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20640
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20640] Idle: test configHelpSourceEdit

[Terry J. Reedy]

Terry J. Reedy added the comment:

Please redo 3.3 patch for current 3.4 (after htest change).

--
title: Adds idle test for configHelpSourceEdit - Idle: test 
configHelpSourceEdit
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20640
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com