[issue20674] Update comments in dictobject.c

Changes by R. David Murray : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue20674] Update comments in dictobject.c

R. David Murray added the comment: Oops, wrong number in the commit message. Thanks for the patch, Jaysinh. New changeset 74109d87283f by R David Murray in branch '3.5': #20647: Update dictobject.c comments to account for randomized string hashes. https://hg.python.org/cpython/rev/74109d87283f

[issue20674] Update comments in dictobject.c

Jaysinh shukla added the comment: Agreeing with "SilentGhost". Demonstrating `hash()` example for type int using list comprehension. Review issue20674_patch_v5.diff Thanks! -- Added file: http://bugs.python.org/file43536/issue20674_patch_v5.diff ___

[issue20674] Update comments in dictobject.c

SilentGhost added the comment: I've left comments on rietveld. Not sure if everyone's seeing them. -- nosy: +SilentGhost stage: needs patch -> patch review ___ Python tracker ___

[issue20674] Update comments in dictobject.c

Jaysinh shukla added the comment: Improving last with with following points: 1. Removing string related examples 2. Updating int example with more readable way (According to me). Reviewer review the patch file named "issue20674_patch_v3.diff" -- Added file: http://bugs.python.org/file43

[issue20674] Update comments in dictobject.c

Terry J. Reedy added the comment: Completely remove all reference to strings as it is normally completely wrong. In three runs of list(map(hash, ("namea", "nameb", "namec", "named"))) I get [-7801965690653662103, -712276634514874737, 4394438508544812081, -6975951345912708912] [-1171799829,

[issue20674] Update comments in dictobject.c

Jaysinh shukla added the comment: Submitting patch which tries to cover mentioned change. I request Core-developers to verify the approach I took for fixing this change. Thanks! -- keywords: +patch nosy: +jaysinh.shukla Added file: http://bugs.python.org/file43510/issue20674_patch_v1.di

[issue20674] Update comments in dictobject.c

Raymond Hettinger added the comment: Christian, I assigned to you because I thought you had done the SIPhash work that invalidated these comments. Do you know who the right person is? -- ___ Python tracker _

[issue20674] Update comments in dictobject.c

Changes by Christian Heimes : -- assignee: christian.heimes -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20674] Update comments in dictobject.c

Changes by Zachary Ware : -- components: +Documentation keywords: +easy stage: -> needs patch versions: +Python 3.5, Python 3.6 ___ Python tracker ___ __

[issue20674] Update comments in dictobject.c

New submission from Raymond Hettinger: The hash function comments in Objects/dictobject.c no longer match the implementation: """ /* Major subtleties ahead: Most has