[issue20766] reference leaks in pdb

daniel hahler added the comment: Please see https://bugs.python.org/issue36667 for a followup. It does not look like moving it to `interaction` is relevant for fixing the leak, is it? I think it should be restored in both places. -- nosy: +blueyed __

[issue20766] reference leaks in pdb

Changes by Donald Stufft : -- pull_requests: +858 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20766] reference leaks in pdb

Jack Liu added the comment: Good to know the fix will be included Python official builds. Thanks. -- ___ Python tracker ___ ___ Python

[issue20766] reference leaks in pdb

Changes by Xavier de Gaye : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20766] reference leaks in pdb

Changes by Xavier de Gaye : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue20766] reference leaks in pdb

Roundup Robot added the comment: New changeset 31a2d270c0c3 by Xavier de Gaye in branch '3.5': Issue #20766: Fix references leaked by pdb in the handling of SIGINT handlers. https://hg.python.org/cpython/rev/31a2d270c0c3 New changeset 86a1905ea28d by Xavier de Gaye in branch '3.6': Issue #20766:

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: Uploaded refleak_5.patch with a simpler test case. With the patch applied, './python -m test -R 3:3 test_pdb' runs with success. The '_previous_sigint_handler' is reset at the Pdb prompt - instead of when the signal is triggered - to handle the case where pdb s

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: > And indeed, this changeset has removed entirely the doctests from the test > suite :( Entered new issue 28338. -- ___ Python tracker ___ ___

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: Oh, test_pdb does not fail anymore in refleak mode as expected (see msg212510 for the change to apply to test_pdb.py in order to reproduce that). 'hg bisect' says that this is happening since: The first bad revision is: changeset: 103552:ee0bbfd9

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: The problem may still be reproduced by running the attached pdb_refleak.py script. Enter three times 'c' (short for the pdb 'continue' command) and the following line is printed: pdb 3 -> pdb 2 -> pdb 1 This shows that the third pdb instance 'pdb 3', owns

[issue20766] reference leaks in pdb

Jack Liu added the comment: Now, I have to set nosigint to True to fix the reference leaks issue for my app. -- ___ Python tracker ___ ___

[issue20766] reference leaks in pdb

Jack Liu added the comment: Will the issue be fixed in Python formal build? I still meet the same issue with Python 3.5.1. It cost me a bit time to track down this issue. I'm using pdb to debug a Python script, there are global variables in the script. Duo the leak of sigint_handler, calling g

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: After refleak_3.patch, test_pdb_next_command_in_generator_for_loop is the only remaining test that sets a breakpoint without reinitializing the breakpoints numbering first. As a result, this test may also fail in the future when tests are reordered by the unit

[issue20766] reference leaks in pdb

Changes by Xavier de Gaye : Added file: http://bugs.python.org/file36163/refleak_3.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: This is because breakpoints number are class attributes. With the following change, the "./python -m test test_pdb test_pdb" is ok: $ hg diff diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py --- a/Lib/test/test_pdb.py +++ b/Lib/test/test_pdb.py @@ -614,

[issue20766] reference leaks in pdb

Antoine Pitrou added the comment: See issue20746 for the test_pdb failure when run multiple times. -- nosy: +pitrou ___ Python tracker ___ ___

[issue20766] reference leaks in pdb

STINNER Victor added the comment: It's not easy to test the patch because running test_pdb fails with the following error (I also get the error if the patch is not applied): $ ./python -m test test_pdb test_pdb [1/2] test_pdb [2/2] test_pdb test test_pdb failed -- Traceback (most recent call la

[issue20766] reference leaks in pdb

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: An improved patch with a test case. -- Added file: http://bugs.python.org/file35349/refleak_2.patch ___ Python tracker ___ _

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: After applying patch 'regrtest.diff' from issue 20746, the command: $ ./python -m test -W -R3:3 test_pdb succeeds now and shows there are no reference leaks. However, with the following change in Lib/test/test_pdb.py and patch 'regrtest.diff' applied: dif

[issue20766] reference leaks in pdb

Xavier de Gaye added the comment: > the first pdb instance is never freed The first pdb instance is (and all the other pdb instances) never freed until the call to PyOS_FiniInterrupts() in Py_Finalize(). -- ___ Python tracker

[issue20766] reference leaks in pdb

New submission from Xavier de Gaye: After the pdb 'continue' command, the signal module owns a reference to Pdb.sigint_handler. On the next instantiation of pdb, the signal module owns a reference to a new sigint_handler method that owns a reference to the previous sigint_handler. As a consequ