[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[STINNER Victor]

STINNER Victor added the comment:

Thanks for the fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[Ezio Melotti]

Ezio Melotti added the comment:

Fixed, thanks for the patch!

--
nosy: +ezio.melotti
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[Roundup Robot]

Roundup Robot added the comment:

New changeset 9ec2b429a607 by Ezio Melotti in branch '3.4':
#20977: fix undefined name in the email module.  Patch by Rose Ames.
http://hg.python.org/cpython/rev/9ec2b429a607

New changeset 944fc499ccd3 by Ezio Melotti in branch 'default':
#20977: merge with 3.4.
http://hg.python.org/cpython/rev/944fc499ccd3

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[Rose Ames]

Rose Ames added the comment:

Thanks guys!  Added minimal tests necessary to expose the bug.

--
Added file: http://bugs.python.org/file35253/expose_bug.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[STINNER Victor]

STINNER Victor added the comment:

I would prefer to see the patch applied if no test can be written.

The bug was not notified before.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[R. David Murray]

R. David Murray added the comment:

It doesn't really matter what order you do it in (though I prefer to write 
tests first, usually), but yes, we will want tests before we commit the fix.

I tried to be thorough in my testing, but obviously I missed some branches :(.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[Rose Ames]

Rose Ames added the comment:

This is my first attempt at contributing to python & I'd really appreciate some 
feedback :).  Should I have added a test to demonstrate the bug before trying 
to fix it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[Rose Ames]

Rose Ames added the comment:

It looks like these are just typos, recording defects to ctype objects when it 
should be disp_header and cte_header?  Apologies if it's more complicated than 
that.

--
keywords: +patch
nosy: +superluser
Added file: http://bugs.python.org/file35212/undefined_ctypes.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[Ezio Melotti]

Changes by Ezio Melotti :


--
keywords: +easy
stage:  -> needs patch
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20977] pyflakes: undefined "ctype" in 2 except blocks in the email module

[STINNER Victor]

Changes by STINNER Victor :


--
title: pyflakes: undefined "ctype" in 2 except blocks -> pyflakes: undefined 
"ctype" in 2 except blocks in the email module

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com