[issue21099] Switch applicable importlib tests to use PEP 451 API

[Eric Snow]

Changes by Eric Snow :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Roundup Robot]

Roundup Robot added the comment:

New changeset fceaa0dc715e by Eric Snow in branch 'default':
Issue #21099: Switch applicable importlib tests to use PEP 451 API.
https://hg.python.org/cpython/rev/fceaa0dc715e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Brett Cannon]

Brett Cannon added the comment:

Patch LGTM

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Brett Cannon]

Brett Cannon added the comment:

I'll try to get to it today or tomorrow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Eric Snow]

Eric Snow added the comment:

Could I get a quick review on this.  There shouldn't be anything surprising or 
controversial here.  I'm pretty confident about the patch and it's pretty 
low-impact so if I don't hear back in the next day or two I'll merge it.

Note: the posted patch does not apply cleanly but the difference is cosmetic.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Mark Lawrence]

Mark Lawrence added the comment:

To echo Brett's question, should this be closed, Eric?

--
status: pending - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21099
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Brett Cannon]

Brett Cannon added the comment:

Should this be closed, Eric?

--
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21099
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Mark Lawrence]

Mark Lawrence added the comment:

Can we have a patch review please as #18864 is dependent on this.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21099
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Eric Snow]

New submission from Eric Snow:

(from msg202657 in issue 18864)

A bunch of importlib (and other?) tests make direct calls to find_module(), 
find_loader(), or load_module().  These are still working, as expected.  
However, we should probably either replace them or supplement them with 
equivalent tests that make use of specs directly.

--
assignee: eric.snow
components: Tests
messages: 215147
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: needs patch
status: open
title: Switch applicable importlib tests to use PEP 451 API
type: enhancement
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21099
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Nick Coghlan]

Nick Coghlan added the comment:

New tests please - we want to make sure these keep working unless/until we 
reach agreement to actually remove them, and I'd prefer not to raise any new 
barriers to migration from Python 2.6/7 until 3.6 at the earliest :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21099
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Eric Snow]

Eric Snow added the comment:

Agreed. :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21099
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21099] Switch applicable importlib tests to use PEP 451 API

[Eric Snow]

Eric Snow added the comment:

Here's a patch.  In most spots I'm left things alone.

There is a comment in the docstring for test_abc.SourceOnlyLoaderTests about 
reload-related tests and module_for_loader (which is deprecated now).  I'm not 
going to worry about that for now.

--
keywords: +patch
stage: needs patch - patch review
Added file: 
http://bugs.python.org/file34663/issue21099-better-use-of-451-api.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21099
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com