Tim Golden added the comment:
I'm at least +0 on this, not because I've ever been that bothered by the Perl
messages, but because it tidies things up a little smooths the way very
slightly for people trying to build Python on Windows and I'm always ready to
support that.
--
Antoine Pitrou added the comment:
+1 for this. The current messages are confusing, and I think I've already
installed Perl because of them.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21141
Martin v. Löwis added the comment:
The patch looks fine to me, including the renaming. Please apply.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21141
___
Roundup Robot added the comment:
New changeset 9ef99fafaadd by Zachary Ware in branch 'default':
Issue #21141: The Windows build process no longer attempts to find Perl,
http://hg.python.org/cpython/rev/9ef99fafaadd
--
nosy: +python-dev
___
Python
Zachary Ware added the comment:
Committed. Thanks for the review, Martin, and for the votes of confidence Tim
and Antoine!
--
assignee: - zach.ware
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Zachary Ware added the comment:
Here's a slightly revised patch, including documentation changes in
PCbuild/readme.txt. Also, this patch doesn't rename build_ssl.(bat|py), so
Rietveld should accept the patch as reviewable. I think the renames should
actually happen, though.
--
Martin v. Löwis added the comment:
Can you please explain what this has to do with dropping the mentioning of Perl?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21141
___
Zachary Ware added the comment:
Sure; currently, the ssl project emits messages from build_ssl.py concerning
the finding of Perl. On a machine with a usable Perl, it's just
Found a working perl at 'C:\Perl\bin\perl.exe'
On machines without Perl, its the more worrisome
Can not
New submission from Zachary Ware:
Attached is a patch that prevents mentioning Perl in the Windows build output,
thereby avoiding giving the indication that Perl is necessary to build Python.
To make this work, the patch converts PCbuild/build_ssl.py into
PCbuild/prepare_ssl.py and removes
