[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Roundup Robot added the comment: New changeset e4da3ba9dcac by Benjamin Peterson in branch '2.7': backport hashlib.pbkdf2_hmac per PEP 466 (closes #21304) http://hg.python.org/cpython/rev/e4da3ba9dcac -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Alex Gaynor added the comment: New patch removes the pdb nonsense in the test. -- Added file: http://bugs.python.org/file35375/pbkdf2.diff ___ Python tracker ___

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Benjamin Peterson added the comment: Looks like there's a debugging turd in the test. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Alex Gaynor added the comment: As a note, the current code is basically identical to the code in Christain's backport, without the py3k compat. -- ___ Python tracker ___ ___

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Alex Gaynor added the comment: Updated patch applies all of MAL's suggestions. Except the buffer() one, the purpose of the buffer() call is to make it an error to pass a list (or random other types) since you can call bytes() on any object. -- Added file: http://bugs.python.org/file353

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Marc-Andre Lemburg added the comment: On 19.05.2014 12:24, Christian Heimes wrote: > > How about you take my back port from > https://bitbucket.org/tiran/backports.pbkdf2/ and remove all Python 3.x > related code? :) I spent a lot of time to make the code as fast as possible. Could you perhap

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Christian Heimes added the comment: Sorry that I join the party rather late. How about you take my back port from https://bitbucket.org/tiran/backports.pbkdf2/ and remove all Python 3.x related code? :) I spent a lot of time to make the code as fast as possible. -- __

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Marc-Andre Lemburg added the comment: Some comments: * Python 2.7 ships with OpenSSL 0.9.8 on Windows, so the Python version will always get used on that platform, so it needs to be fast. * The iterations loop should use xrange instead of range * The .encode('ascii') in _long_to_bin() is n

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Alex Gaynor added the comment: Sorry, I wasn't concerned from a timing attack perspective here, I was concerned from an "oh my god implicit coercion is terrible" perspective :-) -- ___ Python tracker _

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Donald Stufft added the comment: Oh, gotcha. Yea I agree, but it's Python 2.x that's par for the course. -- ___ Python tracker ___ __

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Donald Stufft added the comment: I don't think there's any way around it, nor do I think that it actually leaks any meaningful timing. -- ___ Python tracker ___

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Alex Gaynor added the comment: I'm still concerned about the unicode issue, but I'm not sure what the right way to fix it is. -- ___ Python tracker ___ _

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Donald Stufft added the comment: The attached patch looks pretty good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Alex Gaynor added the comment: New patch includes the documentation as well. -- keywords: +needs review Added file: http://bugs.python.org/file35242/pbkdf2.diff ___ Python tracker __

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Alex Gaynor added the comment: Yup, I've got my eyes on it, if anything lands there I'll include it in this in the 2.7 code, whether it's before or after this patch lands :-) -- ___ Python tracker

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Gregory P. Smith added the comment: See also http://bugs.python.org/issue21288 to consider one fix/oversite/addition to the existing API as part of this process. (discuss that there) by default: use the exact same API as 3.4 if it is suitable for PEP 466 and 2.7.7's needs. the above issue is

[issue21304] PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7

Changes by Nick Coghlan : -- title: PEP 446: Backport hashlib.pbkdf2_hmac to Python 2.7 -> PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7 ___ Python tracker ___ ___