Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 75baef657770 by Meador Inge in branch '2.7':
Issue #2134: Clarify token.OP handling rationale in tokenize documentation.
http://hg.python.org/cpython/rev/75baef657770
New changeset dfd74d752b0e by Meador Inge in
Meador Inge mead...@gmail.com added the comment:
Fixed. Thanks for the reviews everyone.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
___
___
Meador Inge mead...@gmail.com added the comment:
The cmdoption directive should be used with a program directive.
Ah, nice. Thanks for the tip Éric.
Updated patch attached along with a patch for the 2.7/3.2 doc update attached.
--
Added file:
Changes by Meador Inge mead...@gmail.com:
Added file: http://bugs.python.org/file24089/tokenize-docs-2.7-3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
___
Éric Araujo mer...@netwok.org added the comment:
The cmdoption directive should be used with a program directive. See
library/trace for an example of how to use it and to see the anchors and index
entries it generates.
--
nosy: +eric.araujo
___
Meador Inge mead...@gmail.com added the comment:
The proposed documentation text seems too complicated and language expert
speaky to me. We should try to link to standard definitions when possible to
reduce the text here. For example, I believe the Operators and Delimiters
tokens in the
Nick Coghlan ncogh...@gmail.com added the comment:
Meador's patch looks good to me. The docs change for 2.7 and 3.2 would be
similar, just with text like Specific tokens can be distinguished by checking
the ``string`` attribute of OP tokens for a match with the expected character
sequence.
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
___
___
Python-bugs-list
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
___
___
Python-bugs-list
Terry J. Reedy tjre...@udel.edu added the comment:
Both the proposed text and 3.3 addition look good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
___
___
Python-bugs-list
Nick Coghlan ncogh...@gmail.com added the comment:
There are a *lot* of characters with semantic significance that are reported by
the tokenize module as generic OP tokens:
token.LPAR
token.RPAR
token.LSQB
token.RSQB
token.COLON
token.COMMA
token.SEMI
token.PLUS
token.MINUS
token.STAR
Terry J. Reedy tjre...@udel.edu added the comment:
I believe that that list includes all symbols and symbol combinations that are
syntactically significant in expressions. This is the generalized meaning of
'operator' that is being used. What do not appear are '#' which marks comments,
'_'
Nick Coghlan ncogh...@gmail.com added the comment:
Sure, but what does that have to do with anything? tokenize isn't a general
purpose tokenizer, it's specifically for tokenizing Python source code.
The *problem* is that it doesn't currently fully tokenize everything, but
doesn't explicitly
Terry J. Reedy tjre...@udel.edu added the comment:
If you are responding to me, I am baffled. I gave a concise way to document the
current behavior with respect to .OP, which you said you wanted.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
Ah, I didn't read it as suggested documentation at all - you moved seamlessly
from personal commentary to a docs suggestion without separating the two, so it
appeared to be a complete non sequitur to me.
As for the docs suggestion, I think it
17 matches
Mail list logo
