[issue21357] Increase filecmp test coverage from 63% to 76%

diana added the comment: Thanks Benjamin! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue21357] Increase filecmp test coverage from 63% to 76%

Roundup Robot added the comment: New changeset 57dacba9febf by Benjamin Peterson in branch '3.4': improve test coverage of filecmp (closes #21357) http://hg.python.org/cpython/rev/57dacba9febf New changeset c597654a7fd8 by Benjamin Peterson in branch 'default': merge 3.4 (#21357) http://hg.pytho

[issue21357] Increase filecmp test coverage from 63% to 76%

diana added the comment: Nice, the support.catpured_stdout() context manager is much better. I've added a new patch with that change: increase_filecmp_test_coverage__updated_to_use_context_manager.patch Thanks for reviewing this, Benjamin! PS. I signed the contributor agreement.

[issue21357] Increase filecmp test coverage from 63% to 76%

Changes by diana : Removed file: http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch ___ Python tracker ___ ___ Python-bu

[issue21357] Increase filecmp test coverage from 63% to 76%

Changes by diana : Added file: http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch ___ Python tracker ___ ___ Python-bugs

[issue21357] Increase filecmp test coverage from 63% to 76%

Benjamin Peterson added the comment: Thanks for the patch. I think you could use the support.catpured_stdout() context-manager in _assert_report. You should also sign the contributor agreement. -- nosy: +benjamin.peterson ___ Python tracker

[issue21357] Increase filecmp test coverage from 63% to 76%

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue21357] Increase filecmp test coverage from 63% to 76%

Changes by Antoine Pitrou : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue21357] Increase filecmp test coverage from 63% to 76%

New submission from diana: - Increase filecmp test coverage from 63% to 76% - I left the testing style as-is, though it could probably be modernized. - I did not attempt to add coverage for 'funny_files', 'subdirs', etc, next pass perhaps. - Before: diana$ ./python.exe ../coveragepy report -