Éric Araujo added the comment:
IMO either change would not improve the code at all. Suggest closing this.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
Eric V. Smith added the comment:
I disagree. It took me longer than I'd like to admit to track down the file
history and understand it. I'd like to prevent other people from having to try
and understand why it works this way.
On the other hand, it looks like people have discovered it:
Yinon Ehrlich added the comment:
Use the 'abspath' shortcut instead of 'os.path.abspath'
See the attached patch (sorry, forgot to attach before)
--
keywords: +patch
Added file: http://bugs.python.org/file35126/shutil.patch
___
Python tracker
Eric V. Smith added the comment:
Wouldn't it be better to switch uses of abspath to be os.path.abspath? os.path
is used elsewhere in the file, after all.
Brett added from os.path import abspath in
http://hg.python.org/cpython/rev/686e5d38be42 but I think that import should be
deleted and
Changes by Eric V. Smith e...@trueblade.com:
--
stage: - patch review
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
Changes by Yinon Ehrlich yino...@users.sourceforge.net:
--
components: Library (Lib)
nosy: Yinon
priority: normal
severity: normal
status: open
title: PATCH: using the abspath shortcut in Lib/shutil
versions: Python 3.5
___
Python tracker
New submission from Eric V. Smith:
If you meant to supply a patch, it is missing. And in any event, you need to
describe the issue.
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
