[issue21393] Python/random.c: close hCryptProv at exit

2014-05-06 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 2b18f6c37a68 by Tim Golden in branch 'default':
Issue21393 Use CryptReleaseContext to release Crypt handle on Windows
http://hg.python.org/cpython/rev/2b18f6c37a68

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-06 Thread Tim Golden 

Tim Golden added the comment:

Use CryptReleaseContext to release Crypt handle on Windows

--
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Tim Golden 

Tim Golden added the comment:

Unfortunately it looks as though this wasn't the correct way to close a Crypto 
handle. It isn't a conventional handle and we be using CryptReleaseContext to 
close it. cf 
http://msdn.microsoft.com/en-us/library/windows/desktop/aa382041%28v=vs.85%29.aspx
 for example.

At present it's giving a mismatched-pointer warning when building on Windows 
(because it's actually a pointer under the covers and not a simple numerical 
HANDLE).

Simple patch attached

--
Added file: 
http://bugs.python.org/file35155/issue21393.cryptreleasecontext.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Tim Golden 

Changes by Tim Golden m...@timgolden.me.uk:


--
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Tim Golden 

Changes by Tim Golden m...@timgolden.me.uk:


--
resolution: fixed - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Zachary Ware 

Zachary Ware added the comment:

LGTM, Tim.

--
nosy: +zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-02 Thread STINNER Victor 

Changes by STINNER Victor victor.stin...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-02 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 8704198680ba by Victor Stinner in branch 'default':
Issue #21393: random.c: on Windows, close the hCryptProv handle at exit
http://hg.python.org/cpython/rev/8704198680ba

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-04-30 Thread STINNER Victor 

New submission from STINNER Victor:

Attached patch closes hCryptProv handle at Python exit.

--
files: random_closehandle.patch
keywords: patch
messages: 217591
nosy: haypo
priority: normal
severity: normal
status: open
title: Python/random.c: close hCryptProv at exit
versions: Python 3.5
Added file: http://bugs.python.org/file35108/random_closehandle.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-04-30 Thread STINNER Victor 

Changes by STINNER Victor victor.stin...@gmail.com:


--
components: +Windows
nosy: +tim.golden

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-04-30 Thread Stéphane Wirtel 

Stéphane Wirtel added the comment:

+1 for the patch

--
nosy: +matrixise

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-04-30 Thread Tim Golden 

Tim Golden added the comment:

The crypto stuff's not really my area. I agree that the patch looks sane.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21393] Python/random.c: close hCryptProv at exit

2014-04-30 Thread Antoine Pitrou 

Antoine Pitrou added the comment:

Sounds fine to me.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com