Antoine Pitrou added the comment:
The patch looks basically fine. I will make a few tweaks to the comments in the
test case.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21396
___
Antoine Pitrou added the comment:
Actually, with the patch, the universal_newlines tests in test_subprocess hang
(quite logically, since they lack a flush()). I will fix them as well.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 39f2a78f4357 by Antoine Pitrou in branch '3.4':
Issue #21396: Fix TextIOWrapper(..., write_through=True) to not force a flush()
on the underlying binary stream.
http://hg.python.org/cpython/rev/39f2a78f4357
New changeset 37d0c41ed8ad by Antoine
Antoine Pitrou added the comment:
Thank you for the patch!
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21396
___
akira added the comment:
I've uploaded the patch that makes C implementation behave according
to the docs like Python implementation with the corresponding tests.
Issue #21332 is a dependency for this issue: subprocess'
test_universal_newlines needs to be updated to work with Python version.
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21396
___
___
Python-bugs-list
New submission from akira:
related: msg217596 (bufsize=1 is broken if subprocess module uses Python io)
TextIOWrapper.write behavior:
_pyio.py [1]:
if self._line_buffering and (haslf or \r in s):
self.flush()
textio.c [2]:
if (self-write_through)
needflush =
Changes by Ned Deily n...@acm.org:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21396
___
___
Python-bugs-list mailing list
Antoine Pitrou added the comment:
Thanks for the report, Akira. Feel free to submit a patch! (with a test)
--
stage: - needs patch
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21396
