Roundup Robot added the comment:
New changeset 3603bae63c13 by Serhiy Storchaka in branch 'default':
Issue #23326: Removed __ne__ implementations. Since fixing default __ne__
https://hg.python.org/cpython/rev/3603bae63c13
--
___
Python tracker
Roundup Robot added the comment:
New changeset e516badfd3b2 by Serhiy Storchaka in branch '3.4':
Issue #21408: The default __ne__() now returns NotImplemented if __eq__()
https://hg.python.org/cpython/rev/e516badfd3b2
New changeset 7e9880052401 by Serhiy Storchaka in branch 'default':
Issue
Serhiy Storchaka added the comment:
Thank you for your contribution Martin.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
I looked over your __ne__ removals from the library, and they all seem sensible
to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21408
___
Serhiy Storchaka added the comment:
There are few incorrect implementations of __ne__ in the stdlib. Updated patch
removes them. May be we should remove all implementations of __ne__ which are
redundant now.
--
Added file: http://bugs.python.org/file37837/method-not-operator-2.patch
Serhiy Storchaka added the comment:
Particular case of this bug:
class A:
... def __eq__(self, other): return NotImplemented
...
A().__eq__(object())
NotImplemented
A().__ne__(object())
True
The second result should be NotImplemented.
Martin's patch LGTM except few style nitpicks to
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21408
___
___
Python-bugs-list
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21408
___
Martin Panter added the comment:
There is a bit of analysis of the object.__ne__() implementation in Issue 4395.
If my understanding is correct, I think it is a bug that object.__ne__(self,
other) evaluates “not self == other”. It should evaluate “not
self.__eq__(other)” instead, so that
Martin Panter added the comment:
This patch should fix the problem I think. Before the __ne__() implementation
was calling the “==” operator; now it calls the __eq__() method instead.
Also includes extra test for Issue 4395 to avoid having conficting patches.
--
keywords: +patch
Added
New submission from Jean-Paul Calderone:
$ ~/Projects/cpython/3.4/python -c '
class Foo(object):
def __ne__(self, other):
return yup
def __eq__(self, other):
return nope
class Bar(object):
pass
print(object() != Foo(), object() == Foo())
print(Bar() !=
Benjamin Peterson added the comment:
That's because the implicit default __ne__ on Bar returns the opposite of
__eq__.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21408
Josh Rosenberg added the comment:
Why would an subclass of object that doesn't redefine either __eq__ or __ne__
have a different behavior for inequality than object itself? Bar never defined
__eq__, so it shouldn't have an implicit __ne__ any more than object itself
does...
Saying that Bar
Benjamin Peterson added the comment:
The reason ``object() != Foo()`` works is that Foo is a subtype of object(),
so the specialized __ne__ of Foo is called immediately without trying
object.__ne__.
I don't know whether it's a bug.
--
___
Python
R. David Murray added the comment:
I don't think it's a bug. The subclass-goes-first behavior is very
intentional. The implicit __ne__ returning the boolean inverse of __eq__ is
what fooled me when I looked at it.
Or did you mean that following the subclass rule in the case where object is
Benjamin Peterson added the comment:
The subclass behavior is a red herring.
I meant maybe object.__ne__ should check if the other object has a __ne__
method before falling back on ``not object.__eq__()``.
--
___
Python tracker
R. David Murray added the comment:
Oh, I see. Yes, that would seem more consistent.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21408
___
Changes by Florent Xicluna florent.xicl...@gmail.com:
--
nosy: +flox
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21408
___
___
Python-bugs-list
18 matches
Mail list logo
