[issue21467] IDLE icon not included in Windows installer
R. David Murray added the comment: Issue number was mistyped in commit message. Commit was 730eeb10cd81. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Changes by Berker Peksag berker.pek...@gmail.com: -- stage: test needed - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
New submission from Steve Dower: #20406 changed the icon used by IDLE, but forgot to include the new file in the Windows installer. As a result, IDLE won't start. I've attached a patch. 3.4 is unaffected, probably because msi.py changed significantly at some point. (I don't have commit rights, but since I've never actually had a patch accepted I know exactly why. I have a few more changes coming that affect/improve PCBuild and tools\msi, but I'm happy to keep creating issues and patches if that's the right way to make these changes. On the other hand, if someone wants to give me commit rights and say just go for it in these dirs (in my new role as build manager for 2.7/3.5+) I'm okay with that too.) -- components: IDLE, Installation, Windows files: idleico.diff keywords: patch messages: 218220 nosy: benjamin.peterson, loewis, steve.dower, terry.reedy priority: normal severity: normal status: open title: IDLE icon not included in Windows installer type: behavior versions: Python 2.7 Added file: http://bugs.python.org/file35207/idleico.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Martin v. Löwis added the comment: I'll declare this release-critical for the moment; I'm sure Benjamin will properly process it. As for getting access: send your ssh key to hgaccou...@python.org. -- priority: normal - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Tim Golden added the comment: Steve -- re changes to PCBuild c.: worth liaising with Zach Ware (and, to a lesser extent, me) as he's been working through a number of things in that area and I know has other ideas. Just post a patch and nosy us both (zach.ware / tim.golden) Obviously, if it's critical: just do it. -- nosy: +tim.golden, zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Steve Dower added the comment: Martin - sent. I think I need some bits flipped on my account here too. Will/can you take care of that for me? Tim - thanks. My next task was to figure out who else has an interest in this area. I wasn't sure if the 'windows' tag was accurate, but sounds like it is (I should probably get on there as well). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Terry J. Reedy added the comment: Creating issues with patches, so others can comment, is a good idea even when you have commit rights. Adding yourself to https://docs.python.org/devguide/experts.html#experts is a good way to test new commit rights. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Terry J. Reedy added the comment: Steve, I am *really* glad you caught this. We obviously need a new test somewhere that would have caught this before the release. How is the installer tested now? Is it run and the installed python tested with the test suite? If so, a new idle test that runs idlelib/idle.(bat, py, pyw) with subprocess, detects startup errors, and cleanly shuts down the subprocces, would cover the installer. 3.4 is not directly affected because 3.4 Tools/msi/msi.py does not include the patched section if dir==Icons: lib.glob(*.gif) +lib.glob(*.ico) lib.add_file(idle.icns) and .gif and .icns are not in the file. Perhaps the change matches a change in the build process. However, new tests should go on all versions. -- stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Benjamin Peterson added the comment: Yes, by all means, commit it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Steve Dower added the comment: Currently it's an entirely manual process, which is something I intend to work on for 3.5 and beyond. As far as post-mortem on this issue goes, Martin would have found it as well, since I was doing exactly what he said he normally does. The real fix seems to already exist, which is why this only affects 2.7. Installers are just one of those things that are difficult to maintain in a project with lots of contributors, so the more automation the better. (It also helps to have a designated owner, so they can constantly bug people about it without having to feel like they're being annoying... I've learned this in my day job, where I own most of my team's installers.) My commit rights are set up and working. Is anyone opposed to me pushing this fix? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Steve Dower added the comment: Yes, by all means, commit it. Obviously I spent too long writing my last comment :) Pushed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21467] IDLE icon not included in Windows installer
Changes by Steve Dower steve.do...@microsoft.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
