Serhiy Storchaka added the comment:
Here is my plan. First, we should resolve issue22236. Otherwise some tests will
be run with default root created with old wantobjects value. Then we should
introduce new test resource name as in Lilo's first patch (but wantobjects is
not correct name,
Zachary Ware added the comment:
I agree that #22236 should be resolved first. As for resource guarding the
'wantobjects = 0' tests, do we really need to? It takes a bit under 20 seconds
to run all of the tkinter tests on this machine, and I don't think 40 seconds
is an unduly long runtime
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Do not use _default_root in Tkinter tests
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21585
___
Lita Cho added the comment:
Hi Terry,
I had no idea we were moving away from using test_main.
So instead, of using support.run_unittest, we should import all the unittest
from tkinter/test/ and wrap everything with that exec method, setting
wantobjects=1 and again with wantobjects=0?
Also,
Terry J. Reedy added the comment:
The current test/test_*.py example file in the docs intentionally does not
contain test_main.
https://docs.python.org/3/library/test.html#writing-unit-tests-for-the-test-package
The next section explaining that test.regrtest runs
Zachary Ware added the comment:
I've been thinking on this for a while, and haven't come up with a solution
that I like. I haven't had a chance to look at #22236 yet, but I suspect it
will help immensely.
Also, I have a work-in-progress patch for rearranging the tkinter tests into a
Terry J. Reedy added the comment:
My impression is that we are trying to move away from using test_main, or is
using support.run_unittest considered a sufficient change from the old explicit
suite method?
Anyway, here is an alternate approach, adding two lines to wrap all test
classes, that
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21585
___
___
Lita Cho added the comment:
Hi Serhiy,
This patch was made while I was learning tkinter. I figured out how to run the
tests twice while changing wantobjects variable without creating new tests.
Fortunately, all the tests seem to fast when wantobjects is 0 or 1.
The only annoying thing is
Serhiy Storchaka added the comment:
Thanks Lita, but I think it would be better if all Tkinter tests will
automatically run in both wantobjects=0 and wantobjects=1 modes.
As for your patch, ttk.Button() creates default root with current wantobjects
value, this default root can be
Changes by Jessica McKellar jesst...@mit.edu:
--
keywords: +needs review
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21585
___
Changes by Lita Cho lita@gmail.com:
--
nosy: +Lita.Cho, jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21585
___
___
Python-bugs-list
Lita Cho added the comment:
So I don't know what the best way to do this, but I changed the widget_tests.py
in order to set tkinter.wantobjects = 0 if a 'wantobjects' flag was passed
through test.support.use_resources.
Then I added a new test called test_ttk_guionly_wantobj, where it turns
Lita Cho added the comment:
Patches lived in my Linux machine. I've attached my patch. I will add my module
next.
--
keywords: +patch
Added file: http://bugs.python.org/file35394/test_wantobj.patch
___
Python tracker rep...@bugs.python.org
Changes by Lita Cho lita@gmail.com:
Added file: http://bugs.python.org/file35395/test_ttk_guionly_wantobj.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21585
___
New submission from Serhiy Storchaka:
The wantobjects attribute of the tkinter module is True by default, and all
Tkinter tests run with wantobjects=True. We need to test Tkinter with
wantobjects=False too. All Tkinter tests should be ran twice, in both mode.
--
components: Tests,
16 matches
Mail list logo
