Roundup Robot added the comment:
New changeset 1aafbdfba25a by Benjamin Peterson in branch '2.7':
don't allow unicode into type_map on Windows (closes #21652)
http://hg.python.org/cpython/rev/1aafbdfba25a
--
resolution: - fixed
stage: - resolved
status: open - closed
Benjamin Peterson added the comment:
Thanks Vladimir; I really appreciate your work on these issues.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
Vladimir Iofik added the comment:
Finally I got environment and some time.
Attaching patch.
--
keywords: +patch
Added file: http://bugs.python.org/file35795/21652.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
Benjamin Peterson added the comment:
Vladimir, if you could provide a patch implementing your proposed rollback,
that would be appreciated.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
Vladimir Iofik added the comment:
Thanks, Martin. I didn't read the final with enough care. I think the second
part of changes (the ones that are around QueryValueEx) should be rolled back.
I believe the code was correct at that part.
Tim, what do you think?
--
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
___
James Y Knight added the comment:
Reverting the incorrect commit which caused the regression would be a good
start.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
R. David Murray added the comment:
If I understand correct that patch was itself attempting to fix a regression ;)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
Tim Golden added the comment:
Only if you have something better to put in its place! That commit was
fixing an existing problem; perhaps not your problem, but someone's. To
revert it would simply move the pain around.
I hope to be able to work on this fairly soon. If anyone else wants to
Jean-Paul Calderone added the comment:
That commit was fixing an existing problem; perhaps not your problem, but
someone's. To revert it would simply move the pain around.
Doesn't the very same logic apply to the original commit?
I hope to be able to work on this fairly soon.
Thanks.
Vladimir Iofik added the comment:
Did anyone here managed to reproduce the issue?
I tired but I have failed to.
I'm still trying though.
Anyway I'd start from investigating why a function EnumKey returns Unicode
object while according to documentation it should return string.
--
Martin v. Löwis added the comment:
I can reproduce the issue with the attached script. The problem is not that
EnumKey returns a Unicode string (which it never does), but that QueryValueEx
returns a Unicode string. See http://hg.python.org/cpython/rev/18cfc2a42772 for
the actual change in
Gavin Carothers added the comment:
Issue also exists in Pyramid (any wsgi server/framework) See
https://github.com/Pylons/pyramid/issues/1360 for Pyramid bug.
--
nosy: +gcarothers
___
Python tracker rep...@bugs.python.org
Ned Deily added the comment:
If there is a regression to be fixed, there needs to be a patch with a test.
Anyone?
--
nosy: +benjamin.peterson, ned.deily
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
New submission from James Y Knight:
The change done for issue9291 in Python 2.7.7 caused the mimetypes.types_map
dict to change to contain a mixture of str and unicode objects, rather than
just str, as it always had before.
This causes twisted.web to crash when serving static files on
Changes by Jean-Paul Calderone jean-p...@hybridcluster.com:
--
nosy: +exarkun
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
___
16 matches
Mail list logo
