Tal Einat added the comment:
Ouch. I hadn't thought about the Ellipsis literal!
That would be sensibly possible, yes, but not simple. I think opening a
separate issue for this would be prudent.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
#21787 Idle: make 3.x Hyperparser.get_expression recognize ...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21686
___
Terry J. Reedy added the comment:
I forgot to mention that with this particular shutdown order
@classmethod
def tearDownClass(cls):
del cls.text, cls.editwin
cls.root.destroy()
del cls.root
the shutdown warning message we have seen about not handling an event
Roundup Robot added the comment:
New changeset 5063df721985 by Terry Jan Reedy in branch '2.7':
Issue #21686: idlelib/HyperParser.py - Update docstrings and comments and
http://hg.python.org/cpython/rev/5063df721985
New changeset ddf15cf0db72 by Terry Jan Reedy in branch '3.4':
Issue #21686:
Terry J. Reedy added the comment:
Coverage is now '99%'. Unless I see problems that are more than trivial, I am
going to polish the patch and commit.
I believe partial coverage of for context in editwin.num_context_lines: is
because the iterable is never empty. But it never will be in
Roundup Robot added the comment:
New changeset 59730aecce9b by Terry Jan Reedy in branch '2.7':
Issue #21686: add unittest for idlelib.HyperParser. Original patch by Saimadhav
http://hg.python.org/cpython/rev/59730aecce9b
New changeset 2fc89d2230a2 by Terry Jan Reedy in branch '3.4':
Issue
Terry J. Reedy added the comment:
Attached is the 3.4 patch as pushed. The main 'invisible' change, other than
the review comment, was to create the code string just once.
I discovered that the earlier version had a bug in saying 'ok' to the 3.x
HyperParser bug of no longer recognizing
Tal Einat added the comment:
Here are details how to trigger all of the uncovered code lines and branches,
listed by line.
Uncovered lines:
Line 159: This catches would-be identifiers (variable names) which are keywords
or begin with a character that can't be first (e.g. a digit). We should
Tal Einat added the comment:
Regarding lines 32 42, a test could also set editwin.num_context_lines to
allow triggering with smaller code blocks. It's value needs to be a list of
integers, the last of which is incredibly large, perhaps sys.maxint.
--
Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com:
Added file: http://bugs.python.org/file35630/test-hyperparser-v1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21686
___
Terry J. Reedy added the comment:
Since ParenMatch and fixes* to HyperParser depend on this issue, I would like
to do this first. For HyperParser.py, I would like to first commit a clean-up
only patch. The test_hyperparser patch should then only add the 'if __name__'
clause at the end.
I
Tal Einat added the comment:
Which lines are not hit?
--
nosy: +taleinat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21686
___
___
Terry J. Reedy added the comment:
There are 7 scattered conditionals which only evaluate as one of True or False
during tests and 5 lines not hit at all as a result. I am emailing instructions
to install and use coverage package.
--
___
Python
New submission from Saimadhav Heblikar:
Test for idlelib.HyperParser
5 lines not tested. Any suggestion on how to hit those lines welcome.
Will submit backport 2.7 once the patch for 3.4 is OK.
--
components: IDLE
files: test-hyperparser.diff
keywords: patch
messages: 219942
nosy:
14 matches
Mail list logo
