Ezio Melotti added the comment:
Zach, Ezio - if there are any other refactorings from the reviews that
you'd like to pursue, consider pulling them out to separate issues so
we don't forget about them.
See #23560.
--
___
Python tracker
Roundup Robot added the comment:
New changeset e750d2b44c1d by Nick Coghlan in branch '3.4':
Issue #21777: separate docs for binary sequence methods
http://hg.python.org/cpython/rev/e750d2b44c1d
New changeset e205bce4cc0a by Nick Coghlan in branch 'default':
Merge #21777 from 3.4
Nick Coghlan added the comment:
Merged after reviews from Zach Ezio.
Zach, Ezio - if there are any other refactorings from the reviews that you'd
like to pursue, consider pulling them out to separate issues so we don't forget
about them.
--
resolution: - fixed
stage: commit review
Nick Coghlan added the comment:
v5 has all the review comments I accepted as being in scope addressed,
including the restoration/addition of the notes about returning the object
unchanged for center(), ljust(), rjust() and zfill() when the field width is
less than or equal to the length of
Nick Coghlan added the comment:
I think this is done now - absent any major objections, I'll push it live in a
couple of days time.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21777
Nick Coghlan added the comment:
OK, I've completed the initial pass through all the methods. Remaining items:
* add back the guarantees where str will return the same object, add those
guarantees for bytes where applicable
* address the review comments from Zach and Ezio
There are a couple of
Nick Coghlan added the comment:
3rd in progress draft - converted most of the inherently assumes ASCII docs
now. I think this set of changes really makes it clear how non-trivial it
actually is to infer the binary domain behaviour from the str docs, which have
all sorts of Unicode
Nick Coghlan added the comment:
Note I haven't added back the immutability guarantees yet - I'll do that before
declaring this ready for final review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21777
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +chris.jerdonek, ezio.melotti, zach.ware
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21777
___
Nick Coghlan added the comment:
v2 patch converts the second category of functions. This conversion highlighted
the lack of good examples in the str.split() docs, as well as some over and
underspecification in the behaviour of the centering and justification methods
(guarantees about object
Marc-Andre Lemburg added the comment:
Why are you removing guarantees like these from the str docs:
The original string is returned if *width* is less than or equal to
``len(s)``.
?
This doesn't seem to have anything to do with documenting bytes and bytearrays.
--
nosy: +lemburg
Nick Coghlan added the comment:
On 13 Jul 2014 18:39, Marc-Andre Lemburg rep...@bugs.python.org wrote:
Marc-Andre Lemburg added the comment:
Why are you removing guarantees like these from the str docs:
The original string is returned if *width* is less than or equal to
``len(s)``.
Guido van Rossum added the comment:
On Sun, Jul 13, 2014 at 7:00 PM, Nick Coghlan rep...@bugs.python.org
wrote:
Nick Coghlan added the comment:
On 13 Jul 2014 18:39, Marc-Andre Lemburg rep...@bugs.python.org wrote:
Marc-Andre Lemburg added the comment:
Why are you removing
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21777
___
___
Python-bugs-list
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21777
___
___
Python-bugs-list
New submission from Nick Coghlan:
There are currently no dedicated docs for the bytes and bytearray methods - the
relevant section just refers back to the str methods. This isn't sufficient,
since the str methods cover of lot of stuff related to Unicode that isn't
relevant to the binary
16 matches
Mail list logo
