[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-22 Thread Lita Cho
Lita Cho added the comment: Absolutely! I totally forgot I made those changes for PEP8! Next time, I will totally submit just the change associated with the ticket. Thank you, Raymond, for the feedback and reviewing my code! -- ___ Python tracker <

[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks for noticing this and for the patch. In the future, to make patches easier to review, please isolate the core logic change from inconsequential whitespace and linewrap edits. Also note that breaking strings in the middle to accommodate a max line le

[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 39b094798e14 by Raymond Hettinger in branch '3.4': Issue #21812: Trigger immediate transformation in turtle.shapetransform(). http://hg.python.org/cpython/rev/39b094798e14 -- nosy: +python-dev ___ Python

[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-22 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg221228 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: The looks good. Please revise the patch to isolate the actual change in logic and not confound it with PEP-8 nits which make the patch harder to review. Also, please be careful with breaking lines. In the following part of the diff, the space after "matri

[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-20 Thread Lita Cho
Lita Cho added the comment: Have a patch that fixes this. Rather than calling self._update() directory, we should be calling self._pen(resizemode="user"), since the user is changing the size of the turtle, just like how shapesize and shearfactor are updating. -- keywords: +patch Added

[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-19 Thread Lita Cho
New submission from Lita Cho: When you call turtle.shapetransform with a transformation matrix, nothing happens. You have to call turtle.shapesize or turtle.shearfactor first before turtle.shapetransform will take affect. Here is an example. turtle.shapetransform(2,0,0,2) turtle.shapesize(1)

[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-19 Thread Lita Cho
Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or