[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I opened #22051 about removing reload to force better code. Since the tests are passing and I think the demo modules should be minimally tested by importing, and no one has said otherwise since the fix, I am closing this. -- resolution: -> fixed stage

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: The __all__ test now passes on Snow Leapard. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: 2. Done 3. I just removed the setrecursionlimit call, added for 3.0. I moved the colormixer sliders around for longer than anyone is likely to and it ran fine. 4. two-canvases works fine now. The extra window just has to be clicked away. 5. nim had a call to tur

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset c173a34f20c0 by Terry Jan Reedy in branch '2.7': Issue #21882: In turtle demos, remove module scope gui and sys calls by http://hg.python.org/cpython/rev/c173a34f20c0 New changeset fcfa9c5a00fd by Terry Jan Reedy in branch '3.4': Issue #21882: In tu

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am working on the turtle demos now. Victor gave more info in #21884. I was partly wrong in my comments. turtledemo uses reload to re-initialize demos when one switches between them. I am tempted to remove this as part of discouraging side-effects on import.

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-30 Thread R. David Murray
Changes by R. David Murray : -- nosy: +jesstess ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: 6. Add 'good citizenship' note to demohelp.txt. Also point out that all turtle initialiazation should be in main anyway (see 2. and 3. below). Demo should run independently of what other demos do. re 2: If the mode call is needed, it is a bug that it is not ma

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: > 1. test___all__ should be changed to exclude turtledemo modules. Agreed. In general, the test suite shouldn't open any GUI windows except if the "gui" resource is enabled (which isn't the default). The turtledemo behaviour is quite new in that regard. --

[issue21882] turtledemo modules imported by test___all__ cause side effects or failures

2014-06-29 Thread Ned Deily
New submission from Ned Deily: Although the turtledemo modules are not run directly during by "make test" or by "python -m test -uall", they are currently being inadvertently imported by test___all__. This can lead to test failures and side effects because some of the turtledemo modules execu