Roundup Robot added the comment:
New changeset e69f037332a6 by Zachary Ware in branch '3.4':
Issue #21918: Convert test_tools.py to a sub-package of test.
http://hg.python.org/cpython/rev/e69f037332a6
New changeset 1d0ca204c36f by Zachary Ware in branch 'default':
Issue #21918: Convert
Zachary Ware added the comment:
Committed, thanks for the reviews!
I had modeled load_tests after test_json's load_tests. The idiom used in
test_email causes a warning from regrtest about sys.path being modified, so I
modified the idiom slightly and used that. I have declined to backport
Serhiy Storchaka added the comment:
Thanks for your patch. Do you want to correct test_json's and others
load_tests?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21918
___
Zachary Ware added the comment:
Sure, I'll work on that some time this week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21918
___
___
Zachary Ware added the comment:
Here's a new version of the patch in response to review comments. Patch is in
--git format, which means no Rietveld link for this one.
Changes from the first patch:
- Remove Tools/parser/test_unparse.py entirely (moved to Lib/test/test_tools/)
- Remove
Serhiy Storchaka added the comment:
About load_tests() -- look at Lib/test/test_email/__init__.py.
Otherwise LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21918
___
Zachary Ware added the comment:
How about this?
--
keywords: +patch
Added file: http://bugs.python.org/file35905/test_tools.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21918
___
Zachary Ware added the comment:
Here's the same patch in --git format, which should make the actual changes
clearer (though probably not in Rietveld).
--
Added file: http://bugs.python.org/file35906/test_tools.diff--git
___
Python tracker
Changes by Berker Peksag berker.pek...@gmail.com:
--
assignee: - zach.ware
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21918
___
New submission from Serhiy Storchaka:
Lib/test/test_tools.py becomes too large. It includes tests of unrelated
command-lines tools and scripts. It would be good to convert it to directory
containing separate test files for different tools.
--
components: Tests
messages: 222305
nosy:
10 matches
Mail list logo