[issue2196] Fix hasattr's exception problems

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Done in r63119. -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ __

[issue2196] Fix hasattr's exception problems

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list U

[issue2196] Fix hasattr's exception problems

Brett Cannon <[EMAIL PROTECTED]> added the comment: On Tue, Mar 18, 2008 at 4:48 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Further comments? I have not looked at the patch yet (and I don't know when I will get to it). ___

[issue2196] Fix hasattr's exception problems

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Further comments? __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscri

[issue2196] Fix hasattr's exception problems

Benjamin Peterson added the comment: That last patch is malformed. Added file: http://bugs.python.org/file9631/hasattr_fixes2-real.diff __ Tracker <[EMAIL PROTECTED]> __ __

[issue2196] Fix hasattr's exception problems

Benjamin Peterson added the comment: Here's a patch for that. Personally, I'm +1 on either option; I just want it fixed. :) I suppose the only (minor) problem with propagate things which are not Exception is libraries where the exceptions don't extend Exception. However, the ability to do this is

[issue2196] Fix hasattr's exception problems

Paul Pogonyshev added the comment: I think it would be better not to hardcode specific 2 exceptional cases and indeed follow that second way of instanceof(..., Exception). I think it was introduced exactly to separate "things that can be caught by default" from "things that may be caught only in

[issue2196] Fix hasattr's exception problems

Benjamin Peterson added the comment: I suppose another way we could do this is propagate any exception which doesn't inherit Exception. I, however, like just having just those 2 specific exceptions continue. -- assignee: -> georg.brandl __ Tracker <[EMAI

[issue2196] Fix hasattr's exception problems

Brett Cannon added the comment: On Fri, Feb 29, 2008 at 2:04 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson added the comment: > > After looking more closely, I saw that this is documented at > http://www.python.org/dev/patches/style/. So the C uses tabs, and the > Pyt

[issue2196] Fix hasattr's exception problems

Benjamin Peterson added the comment: After looking more closely, I saw that this is documented at http://www.python.org/dev/patches/style/. So the C uses tabs, and the Python uses spaces? Added file: http://bugs.python.org/file9576/hasattr_fixes-good-indentation.diff ___

[issue2196] Fix hasattr's exception problems

Georg Brandl added the comment: Please reformat your patch using tabs. -- nosy: +georg.brandl __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-

[issue2196] Fix hasattr's exception problems

Benjamin Peterson added the comment: Here's a documentation change that explains hasattr's exception issues top accompany my patch. -- components: +Documentation Added file: http://bugs.python.org/file9567/hasattr_docs.diff __ Tracker <[EMAIL PROTECTED]>

[issue2196] Fix hasattr's exception problems

New submission from Benjamin Peterson: hasattr currently returns False when any exception happens in getattr. I see that this tracker I previous patches trying to fix this issue, but they were rejected because they only tried to catch attribute errors. My patch only propagates SystemExit and Keyb