[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.5 ___ Python tracker

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Serhiy Storchaka added the comment: New changeset 94d6434ba7ec3e4b154e515c5583b0b665ab0b09 by Miss Islington (bot) in branch '3.9': [3.9] bpo-21987: Fix TarFile.getmember getting a dir with a trailing slash (GH-30283) (GH-30738)

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

miss-islington added the comment: New changeset 1d11fdd3eeff77ba600278433b7ab0ce4d2a7f3b by Miss Islington (bot) in branch '3.10': bpo-21987: Fix TarFile.getmember getting a dir with a trailing slash (GH-30283) https://github.com/python/cpython/commit/1d11fdd3eeff77ba600278433b7ab0ce4d2a7f3b

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Change by miss-islington : -- nosy: +miss-islington nosy_count: 9.0 -> 10.0 pull_requests: +28924 pull_request: https://github.com/python/cpython/pull/30737 ___ Python tracker

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Change by miss-islington : -- pull_requests: +28925 pull_request: https://github.com/python/cpython/pull/30738 ___ Python tracker ___

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Serhiy Storchaka added the comment: New changeset cfadcc31ea84617b1c73022ce54d4ae831333e8d by andrei kulakov in branch 'main': bpo-21987: Fix TarFile.getmember getting a dir with a trailing slash (GH-30283) https://github.com/python/cpython/commit/cfadcc31ea84617b1c73022ce54d4ae831333e8d

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Serhiy Storchaka added the comment: Well, the tar command strips trailing slashes (even from file paths), so it is reasonable to do this in getmember(). $ mkdir dir $ touch dir/file $ tar cf archive.tar dir $ tar tf archive.tar dir dir/ dir/file $ tar tf archive.tar dir/ dir/ dir/file $ tar

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Andrei Kulakov added the comment: The original issue was twofold: 1. below 100 char not working with trailing slash 2. over 100 char not working WITHOUT trailing slash The second part is no longer an issue -- tested in 3.9 and 3.11 on MacOS. Currently the issue is that a trailing slash now

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Change by Andrei Kulakov : -- nosy: +andrei.avk nosy_count: 8.0 -> 9.0 pull_requests: +28497 pull_request: https://github.com/python/cpython/pull/30283 ___ Python tracker ___

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

STINNER Victor added the comment: > Any updates on this? So far, nobody proposed a pull request. So no, there is no update. Someone has to step in, dig into the issue, propose a fix, then someone else has to review the PR, and finally the PR should be merged. --

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

af added the comment: Any updates on this? -- nosy: +af ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

STINNER Victor added the comment: This issue is 5 years old has 4 patches: it's far from being "newcomer friendly", I remove the "Easy" label. -- keywords: -easy nosy: +vstinner ___ Python tracker

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Changes by Ezio Melotti ezio.melo...@gmail.com: -- stage: test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21987 ___ ___

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Daniel Eriksson added the comment: Added Matt Behrens test to Lars Gustäbel 2.7 version. -- nosy: +dan...@starstable.com Added file: http://bugs.python.org/file36202/issue21987_py2.7_with_test.patch ___ Python tracker rep...@bugs.python.org

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Matt Behrens added the comment: Here is a 3.5 fix based on Lars Gustäbel's, with test. -- nosy: +zigg versions: +Python 3.5 Added file: http://bugs.python.org/file36096/issue21987_py3.5_with_test.patch ___ Python tracker rep...@bugs.python.org

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Lars Gustäbel added the comment: Apparently, the problem is located in TarInfo._proc_gnulong(). I attached a patch. When tarfile reads an archive, it strips trailing slashes from all filenames, except GNUTYPE_LONGNAME headers, which is a bug. tarfile creates GNU_FORMAT tar files by default,

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

R. David Murray added the comment: There is indeed special logic that triggers if the name is longer than 100 characters. Presumably it has a bug. Marking this as easy since it shouldn't be too hard, given the failure example, to figure out what is wrong and fix it (and turn the example

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Brendan Moloney added the comment: Here is a script illustrating the issue. -- Added file: http://bugs.python.org/file35976/tarfile_issue.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21987

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

New submission from Brendan Moloney: If a directory path is under 100 char you have to omit the trailing slash from the name passed to 'getmember'. If it is over 100 you have to include the trailing slash. As a work around I can use the private '_getmember' with 'normalize=True'. I tested on

[issue21987] TarFile.getmember on directory requires trailing slash iff over 100 chars

Serhiy Storchaka added the comment: Could you please provide an example? -- nosy: +lars.gustaebel, serhiy.storchaka stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21987