[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Berker Peksag added the comment: Thanks for the review, Martin, and thanks for the report, Alon! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

miss-islington added the comment: New changeset f19579b8f1fcd2dd8ffaf3e443b09930057c01d1 by Miss Islington (bot) in branch '3.6': bpo-22057: Clarify eval() documentation (GH-8812) https://github.com/python/cpython/commit/f19579b8f1fcd2dd8ffaf3e443b09930057c01d1 --

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

miss-islington added the comment: New changeset 0e1e8dbb0b99ec78f4567382428fdd46e2244d40 by Miss Islington (bot) in branch '3.7': bpo-22057: Clarify eval() documentation (GH-8812) https://github.com/python/cpython/commit/0e1e8dbb0b99ec78f4567382428fdd46e2244d40 -- nosy:

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Change by miss-islington : -- pull_requests: +8297 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Change by miss-islington : -- pull_requests: +8296 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Berker Peksag added the comment: New changeset 225b05548027d55aafb11b65f6a4a2bef2f5196f by Berker Peksag in branch 'master': bpo-22057: Clarify eval() documentation (GH-8812) https://github.com/python/cpython/commit/225b05548027d55aafb11b65f6a4a2bef2f5196f --

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Berker Peksag added the comment: I like Martin's suggestion in msg282262 and I've just created PR 8812 to implement it. -- nosy: +berker.peksag type: -> behavior versions: +Python 3.8 -Python 3.5 ___ Python tracker

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Change by Berker Peksag : -- pull_requests: +8290 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Martin Panter added the comment: “the current mapping of '__builtins__' is copied into *globals* ” That sounds like we insert each individual builtin name, i.e. globals.update(builtins_mapping). But my understanding is that it is the __builtins__ global variable that is affected:

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Raymond Hettinger added the comment: The patch looks good (though it would have been easier to check the diff if the text had not be reflowed). I will apply it when I get a chance. Or if anyone else wants to grab it, go ahead. -- ___ Python

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Antti Haapala added the comment: +1 for this patch, the current documentation states it very wrong. -- nosy: +ztane ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22057 ___

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Alon Mishne added the comment: Patch for 2.7.8. The patch is just changing globals are to mapping of ‘__builtins__’ is, and subsequent paragraph reformatting. -- keywords: +patch Added file: http://bugs.python.org/file36128/evalglobals2.patch ___

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Alon Mishne added the comment: Patch for 3.5.x The patch is just changing globals are to mapping of ‘__builtins__’ is, and subsequent paragraph reformatting. Nearly identical to 2.7.8 patch. -- Added file: http://bugs.python.org/file36129/evalglobals3.patch

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Raymond Hettinger added the comment: Thanks for noticing this. Do you want to propose a patch? -- assignee: docs@python - rhettinger nosy: +rhettinger stage: - needs patch versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

New submission from Alon Mishne: According to the documentation of eval(): If the globals dictionary is present and lacks '__builtins__', the current globals are copied into globals before expression is parsed. However in practice only the __builtins__ items are copied, see: