[issue22080] Add windows_helper module helper

[Eryk Sun]

Eryk Sun  added the comment:

I rewrote windows_helper.py with cleaner ctypes code, better error handling, 
the correct implementation of restoring the previous privilege state, and 
without leaking the handle for the process token. It's kind of limited as a 
"Windows helper" module. It's just handling privileges, at least for now. This 
helper was intended to help with testing bpo-21518 (add winreg.UnLoadKey), 
another contribution from Claudiu.

--
versions: +Python 3.10, Python 3.9 -Python 3.5, Python 3.6
Added file: https://bugs.python.org/file49832/windows_helper.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[eryksun]

Changes by eryksun :


--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[Claudiu Popa]

Claudiu Popa added the comment:

The latest patch drops the symlink check, since it can be added later.

--
Added file: http://bugs.python.org/file39133/issue22080_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[Claudiu Popa]

Claudiu Popa added the comment:

Here's a cleaned up version of the patch.

--
Added file: http://bugs.python.org/file37741/issue22080_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[Zachary Ware]

Zachary Ware added the comment:

eryksun: You commented on my review comment; does Claudiu's latest patch look 
good to you?

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[Claudiu Popa]

Changes by Claudiu Popa :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[Claudiu Popa]

Claudiu Popa added the comment:

The new patch fixes the issues found by Zachary. Thanks for the review!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[Claudiu Popa]

Changes by Claudiu Popa :


Added file: http://bugs.python.org/file36288/issue22080.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22080] Add windows_helper module helper

[Claudiu Popa]

New submission from Claudiu Popa:

Hi. This patch adds a new test helper module, initially added in issue21518, 
for controlling various aspects on Windows platform, like acquiring / releasing 
privileges etc. At the same time, it contains a modification in 
test.support.skip_unless_symlink, so that it tries to acquire the privilege, 
failing otherwise. The only downside is that acquiring 
SeCreateSymbolicLinkPrivilege is only possible for admins and it seems to be 
that they have the privilege by default. On the other hand, for 
SeBackupPrivilege must be explicitly acquired, so the purpose of this module 
isn't redundant.

The part of acquiring a privilege using ctypes is based on similar code by 
Jason R. Coombs.

--
components: Tests
files: windows_helper.patch
keywords: patch
messages: 224050
nosy: Claudiu.Popa, zach.ware
priority: normal
severity: normal
status: open
title: Add windows_helper module helper
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file36108/windows_helper.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com