Roundup Robot added the comment:
New changeset b834b1fa2aab by Berker Peksag in branch '3.4':
Issue #22150: Fix deprecated-removed directive in Sphinx 1.2.
http://hg.python.org/cpython/rev/b834b1fa2aab
New changeset 8f635f77e7e9 by Berker Peksag in branch 'default':
Issue #22150: Fix
Berker Peksag added the comment:
Thank you for your review, Ezio!
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22150
Changes by Berker Peksag berker.pek...@gmail.com:
--
assignee: - berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22150
___
___
Ezio Melotti added the comment:
If the HTML output was fine, what is the purpose of the change in pyspecific.py?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22150
___
Berker Peksag added the comment:
Sorry, I forgot to explain that part of the patch. See
broken-deprecated-removed.png. The Deprecated since version 3.5, will be
removed in 3.6 paragraph should be in the first line, not in the second line
(like the deprecated directive).
--
Ezio Melotti added the comment:
LGTM.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22150
___
___
New submission from Berker Peksag:
The attached patch fixes the problem for me. Tested with Firefox 30.0 and
Chrome 35.0.1916.153 on Ubuntu.
--
components: Demos and Tools
files: deprecated-removed.diff
keywords: patch
messages: 224902
nosy: berker.peksag, georg.brandl
priority: normal
Changes by Berker Peksag berker.pek...@gmail.com:
Added file: http://bugs.python.org/file36282/broken-deprecated-removed.png
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22150
___
Changes by Berker Peksag berker.pek...@gmail.com:
Added file: http://bugs.python.org/file36283/broken-deprecated-removed-2.png
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22150
___
Ezio Melotti added the comment:
Does this fix the extra margin visible in broken-deprecated-removed-2.png?
Is there something in the HTML that causes the extra margin (e.g. an empty
p/p? If that is the reason I think fixing the HTML is better.
--
nosy: +ezio.melotti
Berker Peksag added the comment:
Does this fix the extra margin visible in broken-deprecated-removed-2.png?
Yes.
Is there something in the HTML that causes the extra margin (e.g. an empty
p/p?
I checked the HTML output first, but it was fine. Here's the HTML output of the
11 matches
Mail list logo