Roundup Robot added the comment:
New changeset 97081a80f487 by Benjamin Peterson in branch '2.7':
fix load_verify_locations on unicode paths (closes #22244)
http://hg.python.org/cpython/rev/97081a80f487
--
nosy: +python-dev
resolution: - fixed
stage: - resolved
status: open - closed
Alex Gaynor added the comment:
Attached patch resolves the issue, includes a test.
--
keywords: +needs review, patch
Added file: http://bugs.python.org/file36438/t22244.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22244
Benjamin Peterson added the comment:
Can't you just use et in PyArg_Parse?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22244
___
Alex Gaynor added the comment:
Unfortunately no, the API accepts explicit Nones (in addition to simply not
passing the argument), and et errors on those.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22244
Antoine Pitrou added the comment:
You could do all the argument conversion in the Python SSLContext class and
then delegate to the base _SSLContext class...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22244
Alex Gaynor added the comment:
It's not clear to me that that's better, and it makes the diff with the Python3
version larger.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22244
___
Alex Gaynor added the comment:
Attached patch adds an additional test for a more interesting unicode path.
--
Added file: http://bugs.python.org/file36441/t22244.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22244
New submission from Alex Gaynor:
Details of the issue are here: http://bugs.python.org/msg225613
I'm not sure what the correct API to use is there, perhaps the encoding can be
folded into the PyArg_ParseTupleAndKeywords() call.
--
components: Extension Modules
messages: 225614
nosy:
