[issue22301] smtplib.SMTP.starttls' documentation is just confusing

[Christian Heimes]

Christian Heimes added the comment:

starttls() does accept a ssl_context argument for a while.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22301] smtplib.SMTP.starttls' documentation is just confusing

[Michele Orrù]

Michele Orrù added the comment:

R. David Murray rep...@bugs.python.org writes:

 Since we want to encourage people to use the context, that sounds
 reasonable for 3.x at least. 
Concerning this specific proposition, I really don't see the point in
having .starttls() not simply accepting a SSLContext as argument, as
imaplib.IMAP4.starttls is already doing, for example.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22301
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22301] smtplib.SMTP.starttls' documentation is just confusing

[Michele Orrù]

New submission from Michele Orrù:

maker hello! In 
https://docs.python.org/2/library/smtplib.html#smtplib.SMTP.starttls I read::
maker If keyfile and certfile are provided, these are passed to the socket 
module’s ssl() function.
maker socket.ssl() exists, though it is not documented (not even in 
/dev/library/socket)
maker and furthermore, the link on ssl() points to the ssl module, which is 
just confusing.
bitdancer maker: open an issue.

(I'm noising ap and chris because afaik they were working on the latest ssl 
security stuff)

--
assignee: docs@python
components: Documentation, Library (Lib), email
messages: 226074
nosy: barry, christian.heimes, docs@python, maker, pitrou, r.david.murray
priority: normal
severity: normal
status: open
title: smtplib.SMTP.starttls' documentation is just confusing
versions: Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22301
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22301] smtplib.SMTP.starttls' documentation is just confusing

[Alex Gaynor]

Alex Gaynor added the comment:

Attached patch fixes this up.

--
keywords: +needs review, patch
nosy: +alex
Added file: http://bugs.python.org/file36505/t22301.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22301
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22301] smtplib.SMTP.starttls' documentation is just confusing

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
stage:  - patch review
versions:  -Python 3.1, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22301
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22301] smtplib.SMTP.starttls' documentation is just confusing

[Antoine Pitrou]

Antoine Pitrou added the comment:

Or perhaps we should remove the function to wrap_socket(), which is just an 
implementation detail?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22301
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22301] smtplib.SMTP.starttls' documentation is just confusing

[R. David Murray]

R. David Murray added the comment:

Remove the reference, you mean?  As in just delete the confusing line?  Since 
we want to encourage people to use the context, that sounds reasonable for 3.x 
at least.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22301
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com