[issue22338] test_json crash on memory allocation failure

2014-09-10 Thread STINNER Victor
STINNER Victor added the comment: > Modules/_json.c:1558: item = NULL; > You can move it outside of the loop. I prefer to set item to NULL just after PyList_SET_ITEM() to make it explicit that the list now owns the reference. > But may be it will be better to make this "item" variable local.

[issue22338] test_json crash on memory allocation failure

2014-09-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3ac9f9576ce6 by Victor Stinner in branch '3.4': Issue #22338: Fix a crash in the json module on memory allocation failure. http://hg.python.org/cpython/rev/3ac9f9576ce6 New changeset 135fc23e475c by Victor Stinner in branch 'default': (Merge 3.4) Is

[issue22338] test_json crash on memory allocation failure

2014-09-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Besides my nitpick on Rietveld the patch LGTM. -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue22338] test_json crash on memory allocation failure

2014-09-04 Thread STINNER Victor
Changes by STINNER Victor : -- type: -> crash versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-bugs-li

[issue22338] test_json crash on memory allocation failure

2014-09-04 Thread STINNER Victor
New submission from STINNER Victor: Using pyfailmalloc, I'm able to reproduce the crash seen on a buildbot. Attached patch fixes two bugs in error handlers. http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/8557/steps/test/logs/stdio [191/390] test_urllib2net Fatal Pytho