Roundup Robot added the comment:
New changeset be600ea4ad13 by Serhiy Storchaka in branch '2.7':
Fixed and optimized a test of issue #22526.
https://hg.python.org/cpython/rev/be600ea4ad13
--
___
Python tracker rep...@bugs.python.org
Changes by Benjamin Peterson benja...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22526
___
Serhiy Storchaka added the comment:
Could anyone please test it on Windows?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22526
___
___
Martin Pitt added the comment:
I now raised it to 4 GB for python2.7
This is *still* not enough; I got a success with 6 GB. But this is really
demanding..
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22526
STINNER Victor added the comment:
On Fedora 20/x86_64, running test_file2k takes up to 4.8 GB (5114316 kB) of RSS
memory (VmPeak in /proc/pid/status).
It looks like readahead_get_line_skip() has an efficient code to handle buffer.
It uses recursive calls:
---
readahead: allocate 0.0 MB
Antoine Pitrou added the comment:
Serhiy's patch looks ok to me (haven't tested it).
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22526
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22526
___
Martin Pitt added the comment:
How much memory does that whatever is running that test have?
Our default is 1 GB for our test runner VMs. I now raised it to 4 GB for
python2.7, but we can only do that for our x86 VMs. For other architectures
(ppc64el and ARM) the test VMs just don't have
Serhiy Storchaka added the comment:
Test should be marked with dry_run=False, otherwise it is false passed.
Allocation of growing buffer needs extra memory, in my experiments memuse=2.5
is enough. And I think this test should require the largefile resource. Here is
a patch. It also
Matthias Klose added the comment:
no, it doesn't. at least when testing the installed python installation, it
just fails:
https://jenkins.qa.ubuntu.com/job/utopic-adt-python2.7/39/?
--
nosy: +doko
resolution: fixed -
status: closed - open
___
Benjamin Peterson added the comment:
For insufficient memory not an incorrect fix, though?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22526
___
Matthias Klose added the comment:
maybe, but then you should skip the test, or expect at least a MemoryError.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22526
___
Benjamin Peterson added the comment:
How much memory does that whatever is running that test have?
On Fri, Oct 3, 2014, at 17:17, Matthias Klose wrote:
Matthias Klose added the comment:
maybe, but then you should skip the test, or expect at least a
MemoryError.
--
Changes by R. David Murray rdmur...@bitdance.com:
--
title: file iteration crashes for huge lines (2GiB+) - file iteration
SystemError for huge lines (2GiB+)
type: crash - behavior
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset beadb3e1dc81 by Benjamin Peterson in branch '2.7':
use Py_ssize_t for file offset and length computations in iteration (closes
#22526)
https://hg.python.org/cpython/rev/beadb3e1dc81
--
nosy: +python-dev
resolution: - fixed
stage: -
15 matches
Mail list logo