R. David Murray added the comment:
Made some review comments. The last comment change (deletion) in
unicodeobject.c is not as obvious as the other changes were; I'm not familiar
enough with the C API to know why it is correct. I trust you on that, though :)
--
Serhiy Storchaka added the comment:
Thank you David.
I have left enumerations of concrete bytes-like classes (bytes and bytearray)
because I thought that it is good to be more verbose in the documentation. I
left the decision how write it to you: :class:`bytes`, :class:`bytearray` or
R. David Murray added the comment:
Yeah, just ignore the unicodeobject.c comment comment.
It seems to me that the stuff in the parens is supposed to be a precise
description of what the format code handles, with elaboration in the following
text. So I'd prefer to just use the :term: in those
Roundup Robot added the comment:
New changeset 853e3e115db4 by Serhiy Storchaka in branch '3.4':
Issue #22581: Use more bytes-like object throughout the docs and comments.
https://hg.python.org/cpython/rev/853e3e115db4
New changeset 450a025b1669 by Serhiy Storchaka in branch 'default':
Issue
Serhiy Storchaka added the comment:
Committed with just bytes-like object. Thank you David for your review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
___
Serhiy Storchaka added the comment:
Could anyone please look at the patch? I touches only docs and comments.
--
keywords: +needs review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
Changes by Serhiy Storchaka storch...@gmail.com:
--
Removed message: http://bugs.python.org/msg231643
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
___
Serhiy Storchaka added the comment:
Could anyone please look at the patch? It touches only docs and comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
___
R. David Murray added the comment:
There's no review link. And no obvious reason why there isn't. Could you try
regenerating the patch and uploading it again?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
Serhiy Storchaka added the comment:
Regenerated for review. I don't know why Rietweld didn't like previous patch.
--
Added file: http://bugs.python.org/file37276/bytes_like.patch
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Here is a patch which fixes remnants. It also corrects descriptions of parsing
arguments format units.
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file37169/bytes_like.patch
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
type: - enhancement
versions: +Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
___
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: -skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22581
___
___
Python-bugs-list
New submission from Serhiy Storchaka:
In addition to issue16518. There are other non-fixed messages (may be
introduced after 3.3):
b''.join([''])
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: sequence item 0: expected bytes, bytearray, or an object with the
15 matches
Mail list logo