[issue22581] Other mentions of the buffer protocol

2014-12-05 Thread R. David Murray
R. David Murray added the comment: Made some review comments. The last comment change (deletion) in unicodeobject.c is not as obvious as the other changes were; I'm not familiar enough with the C API to know why it is correct. I trust you on that, though :) --

[issue22581] Other mentions of the buffer protocol

2014-12-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you David. I have left enumerations of concrete bytes-like classes (bytes and bytearray) because I thought that it is good to be more verbose in the documentation. I left the decision how write it to you: :class:`bytes`, :class:`bytearray` or

[issue22581] Other mentions of the buffer protocol

2014-12-05 Thread R. David Murray
R. David Murray added the comment: Yeah, just ignore the unicodeobject.c comment comment. It seems to me that the stuff in the parens is supposed to be a precise description of what the format code handles, with elaboration in the following text. So I'd prefer to just use the :term: in those

[issue22581] Other mentions of the buffer protocol

2014-12-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 853e3e115db4 by Serhiy Storchaka in branch '3.4': Issue #22581: Use more bytes-like object throughout the docs and comments. https://hg.python.org/cpython/rev/853e3e115db4 New changeset 450a025b1669 by Serhiy Storchaka in branch 'default': Issue

[issue22581] Other mentions of the buffer protocol

2014-12-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Committed with just bytes-like object. Thank you David for your review. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581 ___

[issue22581] Other mentions of the buffer protocol

2014-12-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581 ___

[issue22581] Other mentions of the buffer protocol

2014-11-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could anyone please look at the patch? I touches only docs and comments. -- keywords: +needs review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581

[issue22581] Other mentions of the buffer protocol

2014-11-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- Removed message: http://bugs.python.org/msg231643 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581 ___

[issue22581] Other mentions of the buffer protocol

2014-11-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could anyone please look at the patch? It touches only docs and comments. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581 ___

[issue22581] Other mentions of the buffer protocol

2014-11-25 Thread R. David Murray
R. David Murray added the comment: There's no review link. And no obvious reason why there isn't. Could you try regenerating the patch and uploading it again? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581

[issue22581] Other mentions of the buffer protocol

2014-11-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Regenerated for review. I don't know why Rietweld didn't like previous patch. -- Added file: http://bugs.python.org/file37276/bytes_like.patch ___ Python tracker rep...@bugs.python.org

[issue22581] Other mentions of the buffer protocol

2014-11-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which fixes remnants. It also corrects descriptions of parsing arguments format units. -- keywords: +patch stage: needs patch - patch review Added file: http://bugs.python.org/file37169/bytes_like.patch

[issue22581] Other mentions of the buffer protocol

2014-10-31 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- type: - enhancement versions: +Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581 ___

[issue22581] Other mentions of the buffer protocol

2014-10-14 Thread Stefan Krah
Changes by Stefan Krah stefan-use...@bytereef.org: -- nosy: -skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22581 ___ ___ Python-bugs-list

[issue22581] Other mentions of the buffer protocol

2014-10-08 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In addition to issue16518. There are other non-fixed messages (may be introduced after 3.3): b''.join(['']) Traceback (most recent call last): File stdin, line 1, in module TypeError: sequence item 0: expected bytes, bytearray, or an object with the