[issue22642] trace module: convert to argparse

Berker Peksag added the comment: Thanks, Senthil. My comment was for Vajrasky's patch, not for the whole argparse switch. We need to add tests for the old getopt code first to avoid regressions. After 0aa46b9ffba3, if we add tests we won't be able to test the old interface. My other comments:

[issue22642] trace module: convert to argparse

Senthil Kumaran added the comment: Thanks for the contribution. The option handling of trace module is modernized now. As berker suggested in one of the review comments, this module could see an increase in test coverage and we could deal with this as separate ticket. -- resolution:

[issue22642] trace module: convert to argparse

Roundup Robot added the comment: New changeset 69aa17b1f894 by Senthil Kumaran in branch 'default': Add a NEWS entry for Issue #22642. https://hg.python.org/cpython/rev/69aa17b1f894 -- ___ Python tracker __

[issue22642] trace module: convert to argparse

Roundup Robot added the comment: New changeset 0aa46b9ffba3 by Senthil Kumaran in branch 'default': Issue22642 - Convert trace module's option handling mechanism from getopt to argparse. https://hg.python.org/cpython/rev/0aa46b9ffba3 -- nosy: +python-dev ___

[issue22642] trace module: convert to argparse

SilentGhost added the comment: Here is the updated version of the patch that addresses Senthil's comments. Besides re-flowing code, I've also added enforcement of --summary switch and re-factored and expanded the test_failures. It probably would be good if someone could test this on a real-lif

[issue22642] trace module: convert to argparse

Senthil Kumaran added the comment: @SilentGhost, Thanks a lot for the quick turn around of a patch. I have left some review comments in reitveld. Please address them. Since this is underlying implementation change in option processing/parsing, it should only in feature release (3.6). Thank

[issue22642] trace module: convert to argparse

SilentGhost added the comment: Here is the patch that incorporates earlier changes from Vajrasky's patch as well as wording from Evan's patch in issue24649. I've extended the test of failures, but I'm not sure if much can be done about the test of successful executions. I'm going to mark this