[issue22758] Regression in Python 3.2 cookie parsing

Roundup Robot added the comment: New changeset a0bf31e50da5 by Martin Panter in branch '3.2': Issue #22758: Move NEWS entry to Library section https://hg.python.org/cpython/rev/a0bf31e50da5 -- ___ Python tracker

[issue22758] Regression in Python 3.2 cookie parsing

Roundup Robot added the comment: New changeset 1c07bd735282 by R David Murray in branch '3.3': #22758 null merge https://hg.python.org/cpython/rev/1c07bd735282 New changeset 5b712993dce5 by R David Murray in branch '3.4': #22758 null merge https://hg.python.org/cpython/rev/5b712993dce5 New

[issue22758] Regression in Python 3.2 cookie parsing

R. David Murray added the comment: Oops. I guess there's no commit hook after all. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue22758] Regression in Python 3.2 cookie parsing

Roundup Robot added the comment: New changeset d22fadc18d01 by R David Murray in branch '3.2': #22758: fix regression in handling of secure cookies. https://hg.python.org/cpython/rev/d22fadc18d01 -- nosy: +python-dev ___ Python tracker

[issue22758] Regression in Python 3.2 cookie parsing

R. David Murray added the comment: My understanding is that there is a commit hook that prevents pushing to the 3.2 branch, so that Georg needs to do this. I've applied the patch and run the tests myself, and agree that it passes (as in, none of the test failures I see are related to

[issue22758] Regression in Python 3.2 cookie parsing

Berker Peksag added the comment: I will commit this to the 3.2 branch today. -- status: closed -> open ___ Python tracker ___

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: Given the inactivity here, I guess the patch won't be applied before Python 3.2 is end-of-life so I'm going to close the ticket. -- resolution: -> wont fix status: open -> closed ___ Python tracker

[issue22758] Regression in Python 3.2 cookie parsing

Changes by Berker Peksag : -- stage: -> commit review ___ Python tracker ___ ___

[issue22758] Regression in Python 3.2 cookie parsing

Changes by Tim Graham timogra...@gmail.com: Added file: http://bugs.python.org/file39512/secure-httponly-3.2-backport.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: Patch rebased again after cookie fix from #22931. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___ ___

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: Patch updated to fix conflict in NEWS. Could we have it committed to ensure it gets fixed in the next 3.2 released? -- Added file: http://bugs.python.org/file38609/secure-httponly-3.2-backport.diff ___ Python tracker

[issue22758] Regression in Python 3.2 cookie parsing

Changes by Mike Gilbert floppymas...@gmail.com: -- nosy: +floppymaster ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___ ___

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: The patch from #16611 applies cleanly to 3.2. I added a mention in Misc/NEWS and confirmed that all tests pass. -- Added file: http://bugs.python.org/file37127/secure-httponly-3.2-backport.diff ___ Python tracker

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: I also created #22796 for the lax parsing issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___ ___

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: Georg, how do want to proceed with this issue? Should we backport #16611 (support for parsing secure/httponly flag) to 3.2 to fix this regression and then create a separate issue to fix the lax parsing issue on all versions? --

[issue22758] Regression in Python 3.2 cookie parsing

Georg Brandl added the comment: That seems like the best course of action. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___ ___

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: FYI, I created #22775 and submitted a patch for the issue that SimpleCookie doesn't pickle properly with HIGHEST_PROTOCOL. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758

[issue22758] Regression in Python 3.2 cookie parsing

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___

[issue22758] Regression in Python 3.2 cookie parsing

New submission from Tim Graham: I noticed some failing Django tests on Python 3.2.6 the other day. The regression is caused by this change: https://github.com/python/cpython/commit/572d9c59a1441c6f8ffb9308824c804856020e31 Behavior before that commit (and on other version of Python even after

[issue22758] Regression in Python 3.2 cookie parsing

Antoine Pitrou added the comment: Is it a normal use of SimpleCookie? The docs don't seem to imply it: C = cookies.SimpleCookie() C.load(chips=ahoy; vienna=finger) # load from a string (HTTP header) In any case, it's up to Georg to decide. But changeset

[issue22758] Regression in Python 3.2 cookie parsing

Antoine Pitrou added the comment: Can you give a pointer to the failing Django test, by the way? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: I wasn't sure if it was expected behavior or not. I'm attaching a file with the list of failing tests on Django's master. Perhaps more useful is a reference to the problematic usage in Django:

[issue22758] Regression in Python 3.2 cookie parsing

Antoine Pitrou added the comment: Ah, so it's about round-tripping between SimpleCookie.__str__() and SimpleCookie.__init__(). That sounds like a reasonable behaviour to preserve (and easier than parsing arbitrary Set-Cookie headers). IMO we should also add for tests for it in other versions.

[issue22758] Regression in Python 3.2 cookie parsing

Georg Brandl added the comment: OK, so there are two root issues here: * Django uses __init__(str()) roundtripping, which is not explicitly supported by the library, and worked by accident with previous versions. That it works again with 3.3+ is another accident, and a bug. (The change for

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: Thank-you Georg; I believe I was able to fix some of the failures by patching Django as you suggested. However, I think I found another issue due to #16611 (support for httponly/secure cookies) not being backported to Python 3.2. The issue is that any cookies

[issue22758] Regression in Python 3.2 cookie parsing

Georg Brandl added the comment: Thanks, this is indeed a regression. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22758 ___ ___