[issue22815] unexpected successes are not output

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue22815] unexpected successes are not output

Serhiy Storchaka added the comment: New changeset 1944434b44e0118e812bf63f47b268ff6dd0c8f1 by Serhiy Storchaka in branch 'main': bpo-22815: Print unexpected successes in summary in TextTestResult (GH-30138) https://github.com/python/cpython/commit/1944434b44e0118e812bf63f47b268ff6dd0c8f1

[issue22815] unexpected successes are not output

Serhiy Storchaka added the comment: Unless you tun tests in verbose mode you do not know which of tests was unexpectedly successful. And even in the verbose mode it is not easy to find that test in long output. Yes, unexpected successes considered successes in earlier versions. See

[issue22815] unexpected successes are not output

Irit Katriel added the comment: I know that in unittest2 an unexpected success did not cause the test to fail (when we moved from unittest2 to unittest at work we got test failures due to unexpected successes that previously did not show up). I don't know the whole history of how unittest2

[issue22815] unexpected successes are not output

Irit Katriel added the comment: Yes, this is why I don’t understand the request here. When a test fails you know which assertion was violated or which line raised an exception. When a multi line test succeeds, you don’t know which line was supposed to fail. --

[issue22815] unexpected successes are not output

Serhiy Storchaka added the comment: There are no other details for unexpected successes, only test descriptions. -- type: behavior -> enhancement ___ Python tracker ___

[issue22815] unexpected successes are not output

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +28356 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30138 ___ Python tracker

[issue22815] unexpected successes are not output

Serhiy Storchaka added the comment: I think the OP means that test details (test description, traceback, captured output) are printed for ERROR and FAIL in TextTestResult.printErrors(). Other possible results besides error and failure are success, skipped, expected failure and unexpected

[issue22815] unexpected successes are not output

Irit Katriel added the comment: I don't think adding more information from the test would be helpful - when a test fails you have (and need) information about what happened. But when a test succeeds the code of the test basically tells you what happened - all the assertions passed. I think

[issue22815] unexpected successes are not output

Irit Katriel added the comment: In verbose mode we do get output like the one in the code.google issue: % cat tmp.py import unittest class TestStringMethods(unittest.TestCase): @unittest.expectedFailure def test_upper(self): self.assertEqual(2, 2) def test_lower(self):

[issue22815] unexpected successes are not output

Irit Katriel added the comment: Or do you mean that there should be more output? -- status: pending -> open ___ Python tracker ___

[issue22815] unexpected successes are not output

Irit Katriel added the comment: I think this has been fixed: % cat mm.py import unittest class TestStringMethods(unittest.TestCase): @unittest.expectedFailure def test_upper(self): self.assertEqual(2, 2) if __name__ == '__main__': unittest.main() % ./python.exe

[issue22815] unexpected successes are not output

New submission from Robert Collins: Unexpected successes cause failures, but we don't output details about them at the end of the run. From https://code.google.com/p/unittest-ext/issues/detail?id=22 A complicating factor is that we don't have a backtrace to show - but we may have captured