[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-22 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks folks - Zach's right, that wasn't supposed to move. I missed the second copy in pylifecycle.c because it's all #ifdef'ed out on Linux, so the linker didn't complain about the duplication. -- ___ Python tracker

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-21 Thread Steve Dower
Steve Dower added the comment: That should be the last fix for Windows - a bit of code that was copied into the new file but not removed from the old one. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22869

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset e7df0a47af16 by Steve Dower in branch 'default': Issue #22869: Remove duplicate stack check from pythonrun.c https://hg.python.org/cpython/rev/e7df0a47af16 -- ___ Python tracker rep...@bugs.python.org

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-21 Thread Zachary Ware
Zachary Ware added the comment: Steve, I was actually just minutes away from committing the same fix in the opposite direction when I got the notification of your commit. Nick will correct me if I'm wrong but I think PyOS_CheckStack was supposed to stay in pythonrun.c, especially since it's

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-21 Thread Steve Dower
Steve Dower added the comment: You may be right, I didn't think of looking in the include files. I assumed that it was copied without being removed, rather than the copy itself being accidental. Feel free to move it back. -- ___ Python tracker

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 406965684327 by Zachary Ware in branch 'default': Closes #22869: Move PyOS_CheckStack back to pythonrun.c https://hg.python.org/cpython/rev/406965684327 -- status: open - closed ___ Python tracker

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset b9775a92c1d0 by Nick Coghlan in branch 'default': Issue #22869: Split pythonrun into two modules https://hg.python.org/cpython/rev/b9775a92c1d0 -- nosy: +python-dev ___ Python tracker

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Nick Coghlan
Changes by Nick Coghlan ncogh...@gmail.com: -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22869 ___

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Mark Lawrence
Mark Lawrence added the comment: I'm not absolutely sure but I think this has broken the Windows builds with the following being typical of numerous errors. 2main.obj : error LNK2019: unresolved external symbol _Py_Finalize referenced in function _Py_Main 2main.obj : error LNK2019: unresolved

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks. The Windows build files (Visual Studio project files) typically have to be updated when a new C file is added to the source tree. Probably one of our Windows experts can help with that :-) -- nosy: +steve.dower, tim.golden, zach.ware status:

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 31fd106bb68a by Steve Dower in branch 'default': Issue #22869: Add pylifecycle.c/.h files to pythoncore project. https://hg.python.org/cpython/rev/31fd106bb68a -- ___ Python tracker

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Steve Dower
Steve Dower added the comment: Fixed. (I was conveniently sitting waiting for other things to build...) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22869 ___

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Mark Lawrence
Mark Lawrence added the comment: 2 getbuildinfo.c 2pythonrun.obj : error LNK2005: _PyOS_CheckStack already defined in pylifecycle.obj 2 Creating library C:\cpython\PCbuild\python35.lib and object C:\cpython\PCbuild\python35.exp 2C:\cpython\PCbuild\python35.dll : fatal error LNK1169: one

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Steve Dower
Steve Dower added the comment: Looks like a few Windows only things were missed. Can you track them down and get them into a patch? I'm out of time to do more right now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22869

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-20 Thread Mark Lawrence
Mark Lawrence added the comment: Out of my depth I'm afraid, sorry :( -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22869 ___ ___

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: +1 on the principle. reference count printing is duplicated (lifecycle prints it at shutdown, pythonrun at the interactive prompt) You could make it an API in object.c. * pythonrun references PyInspect_Flag directly without an extern declaration *

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-15 Thread Nick Coghlan
Nick Coghlan added the comment: It turns out *all* the global config variations are in pydebug.h (and they're basically the only thing in there, aside from the environment variable access macro). That seems a little weird to me (perhaps historical due to the early global config variables

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-15 Thread Nick Coghlan
Nick Coghlan added the comment: I think this is ready to go now, unless anyone spots any major flaws I missed. -- stage: patch review - commit review Added file: http://bugs.python.org/file37204/split_pythonrun_v3.diff ___ Python tracker

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-15 Thread Nick Coghlan
Nick Coghlan added the comment: Oops, global config variations above should have been global config variable declarations. I guess my brain decided that was too much typing and jammed the last two words together :) -- ___ Python tracker

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-14 Thread Nick Coghlan
New submission from Nick Coghlan: When working on the original reference implementation for PEP 432, I found it useful to split the startup shutdown code out from the main entry points into the eval loop (see issue 22257 for more details). However, that split made the draft implementation

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-14 Thread Nick Coghlan
Nick Coghlan added the comment: Incorporated pythonrun changes from 668e0bf30042, 6aaa0aab1e93 and d6fb87972dee into pylifecycle -- Added file: http://bugs.python.org/file37195/split_pythonrun_v2.diff ___ Python tracker rep...@bugs.python.org

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-14 Thread Nick Coghlan
Nick Coghlan added the comment: Known issues with the current split: * reference count printing is duplicated (lifecycle prints it at shutdown, pythonrun at the interactive prompt) * pythonrun references PyInspect_Flag directly without an extern declaration * This particular oddity wasn't

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-14 Thread Barry A. Warsaw
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22869 ___ ___ Python-bugs-list mailing

[issue22869] Split pylifecycle.c out from pythonrun.c

2014-11-14 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22869 ___