Cheryl Sabella added the comment:
@John.McKay, would you be interested in converting your patch to a Github pull
request on the master branch?
--
nosy: +csabella
versions: +Python 3.7 -Python 3.4, Python 3.5
___
Python tracker
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: -demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22946
___
___
Demian Brecht added the comment:
+1 to the addition of a test. Also, I know it's only related, but it might be
nice to also have this fixed in http_error_default:
https://hg.python.org/cpython/file/021c1df36910/Lib/urllib/request.py#l2003.
--
nosy: +demian.brecht
John McKay added the comment:
For the test can I assume that we have the openssl binary in the path? The
other tests just use a static response to emulate the server, but without being
able to use s_client it would be quite a bit more effort to fake a working HTTP
server with TLS so that it
Benjamin Peterson added the comment:
We have a testing HTTPS server in Lib/test/ssl_servers.py.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22946
___
New submission from John McKay:
After getting a sucessfull response, _open_generic_http will overwrite the the
start of the url to be http: regardless of if it was called from open_http() or
open_https(). This causes it to appear as if you were redirected to a
non-secure site if you check the
Benjamin Peterson added the comment:
Thank you for the patch. It would be nice to have a test, too.
--
nosy: +benjamin.peterson
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22946