[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Brett Cannon added the comment: Apparently this broke under Windows: http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/8999/steps/test/logs/stdio -- status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Barry A. Warsaw added the comment: I already pushed a fix. http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.4/builds/702/steps/test/logs/stdio (although asyncio is still failing there but that should be unrelated) -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Matthias Klose added the comment: seen as well with 3.3 -- keywords: +3.3regression, 3.4regression nosy: +doko ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Matthias Klose added the comment:
proposed patch:
diff -r 8dacb1a21793 Lib/importlib/_bootstrap.py
--- a/Lib/importlib/_bootstrap.py Fri Nov 28 13:15:41 2014 +0100
+++ b/Lib/importlib/_bootstrap.py Mon Dec 01 17:05:00 2014 +0100
@@ -453,7 +453,7 @@
else:
suffixes = OPTIMIZED_BYTECODE_SUFFIXES
head, tail = _path_split(path)
-base_filename, sep, _ = tail.partition('.')
+base_filename, sep, _ = tail.rpartition('.')
tag = sys.implementation.cache_tag
if tag is None:
raise NotImplementedError('sys.implementation.cache_tag is None')
--
stage: test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22966
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Barry A. Warsaw added the comment: I'll take this one. I think it should be easy to add a test case, which I'll do. -- assignee: - barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Changes by Barry A. Warsaw ba...@python.org: -- versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Barry A. Warsaw added the comment: Not counting importlib.h, here's the diff I'm going to apply to 3.4. It passes all the existing tests and includes a new test for this behavior. -- Added file: http://bugs.python.org/file37339/22966.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Roundup Robot added the comment: New changeset 269bf37a57a1 by Barry Warsaw in branch '3.4': - Issue #22966: Fix __pycache__ pyc file name clobber when pyc_compile is https://hg.python.org/cpython/rev/269bf37a57a1 New changeset 3b3ba38d503a by Barry Warsaw in branch '3.4': - Issue #22966: Fix __pycache__ pyc file name clobber when pyc_compile is https://hg.python.org/cpython/rev/3b3ba38d503a New changeset 25113281d543 by Barry Warsaw in branch 'default': - Issue #22966: Fix __pycache__ pyc file name clobber when pyc_compile is https://hg.python.org/cpython/rev/25113281d543 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Changes by Barry A. Warsaw ba...@python.org: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Changes by Berker Peksag berker.pek...@gmail.com: -- stage: patch review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
R. David Murray added the comment: And, therefore, a missing test :(. This probably snuck in when we refactored the CLI. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
New submission from Piotr Ożarowski: when py_compile module is asked to create .pyc file for file with invalid name, it doesn't fail or ignore such request - it creates/overwrites .pyc file for sane file name (i.e. ignores everything after dot) $ touch foo.bar.py $ python3.4 -m py_compile foo.bar.py $ ls __pycache__ foo.cpython-34.pyc Even though foo.bar.py is not a valid file name, some programmers are using such names for plugins which leads to bugs similar to https://lists.debian.org/debian-python/2014/11/msg00061.html. I will update my scripts to not feed py_compile module with file names containing dot (and remove already generated .pyc files if such files are detected), but please do not generate them or generate .pyc files with invalid file names as well. -- messages: 231859 nosy: piotr priority: normal severity: normal status: open title: py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Changes by Brett Cannon br...@python.org: -- components: +Library (Lib) stage: - test needed type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Changes by Brett Cannon br...@python.org: -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22966] py_compile: foo.bar.py → __pycache__/foo.cpython-34.pyc
Piotr Ożarowski added the comment: Python 3.2 generates foo.bar.cpython-32.pyc so it's a regression -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22966 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
