[issue22968] Lib/types.py nit: isinstance != PyType_IsSubtype

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +yselivanov
stage:  -> patch review
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22968] Lib/types.py nit: isinstance != PyType_IsSubtype

[Greg Turner]

Greg Turner added the comment:

Just added a commit message.

--
Added file: http://bugs.python.org/file37349/fix_types_calculate_meta_v3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22968
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22968] Lib/types.py nit: isinstance != PyType_IsSubtype

[Greg Turner]

Greg Turner added the comment:

Here are some tests for this... first, some tests that pass right now and 
demonstrate, I think, correctness of the second batch of tests.

--
Added file: http://bugs.python.org/file37350/test_virtual_metaclasses.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22968
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22968] Lib/types.py nit: isinstance != PyType_IsSubtype

[Greg Turner]

Greg Turner added the comment:

And some analogous tests for types.py, which don't pass without 
fix_types_calculate_meta_v3.patch.

--
Added file: 
http://bugs.python.org/file37351/test_virtual_metaclasses_in_types_module.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22968
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22968] Lib/types.py nit: isinstance != PyType_IsSubtype

[Greg Turner]

Greg Turner added the comment:

And some analogous tests for types.py, which don't pass without 
fix_types_calculate_meta_v3.patch.

--
Added file: 
http://bugs.python.org/file37352/test_virtual_metaclasses_in_types_module.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22968
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22968] Lib/types.py nit: isinstance != PyType_IsSubtype

[Greg Turner]

Greg Turner added the comment:

Fixed a trivial typo in test_virtual_metaclass_in_types_module.patch

--
versions: +Python 3.5
Added file: 
http://bugs.python.org/file37356/test_virtual_metaclasses_in_types_module_v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22968
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22968] Lib/types.py nit: isinstance != PyType_IsSubtype

[Greg Turner]

Changes by Greg Turner g...@be-evil.net:


--
title: types._calculate_meta nit: isinstance != PyType_IsSubtype - 
Lib/types.py nit: isinstance != PyType_IsSubtype

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22968
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com