[issue22986] Improved handling of __class__ assignment

Eric Snow added the comment: The gmane link isn't working for me. Here's the mailing list archive thread: https://mail.python.org/pipermail/python-dev/2014-November/thread.html#137262 https://mail.python.org/pipermail/python-dev/2014-December/thread.html#137370 --

[issue22986] Improved handling of __class__ assignment

Nick Coghlan added the comment: Just noting I filed http://bugs.python.org/issue27505 regarding the lack of documentation for the new-in-Python-3.5 ability to set module __class__ attributes. -- ___ Python tracker

[issue22986] Improved handling of __class__ assignment

Roundup Robot added the comment: New changeset c0d25de5919e by Benjamin Peterson in branch 'default': allow changing __class__ between a heaptype and non-heaptype in some cases (closes #22986) https://hg.python.org/cpython/rev/c0d25de5919e -- resolution: - fixed stage: patch review -

[issue22986] Improved handling of __class__ assignment

Roundup Robot added the comment: New changeset d3671e6ba106 by Benjamin Peterson in branch 'default': merge 3.4 (#22986) https://hg.python.org/cpython/rev/d3671e6ba106 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org

[issue22986] Improved handling of __class__ assignment

Benjamin Peterson added the comment: (That message should have gone to #23250.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22986 ___ ___

[issue22986] Improved handling of __class__ assignment

Benjamin Peterson added the comment: Why do you have all these special cases of ref-counting based on Py_TPFLAGS_HEAPTYPE? static types are generally ref-counted, too. (They just hopefully don't reach 0 often. :)) -- ___ Python tracker

[issue22986] Improved handling of __class__ assignment

Benjamin Peterson added the comment: Oh, I forgot references to non-heaptypes in the header don't count... objects now being able to transmute between heap and heap-type really makes for a nice can of worms. -- ___ Python tracker

[issue22986] Improved handling of __class__ assignment

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +benjamin.peterson stage: - patch review type: - enhancement versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22986

[issue22986] Improved handling of __class__ assignment

Nathaniel Smith added the comment: I hereby invoke the one month ping rule! Patch, be pinged! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22986 ___

[issue22986] Improved handling of __class__ assignment

New submission from Nathaniel Smith: Following on from the discussion starting here: http://thread.gmane.org/gmane.comp.python.devel/150438/focus=150604 Here's a patch to improve __class__ assignment. 1) We remove the HEAPTYPE check from object_set_class, and move it to same_slots_added.

[issue22986] Improved handling of __class__ assignment

Changes by Ethan Furman et...@stoneleaf.us: -- nosy: +ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22986 ___ ___ Python-bugs-list

[issue22986] Improved handling of __class__ assignment

Nathaniel Smith added the comment: Here's a slightly improved patch spurred by a parenthetical comment of Antoine's on the mailing list :-). The only change is that it adds a check in subclass_dealloc to correct the reference counting in the weird case that someone converts a HEAPTYPE object

[issue22986] Improved handling of __class__ assignment

Changes by Nick Coghlan ncogh...@gmail.com: -- nosy: +ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22986 ___ ___ Python-bugs-list

[issue22986] Improved handling of __class__ assignment

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22986 ___ ___ Python-bugs-list