Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
___
___
Roundup Robot added the comment:
New changeset c6491d91d59a by Serhiy Storchaka in branch '2.7':
Issue #23071: Added missing names to codecs.__all__. Patch by Martin Panter.
https://hg.python.org/cpython/rev/c6491d91d59a
New changeset 2b642f2ca391 by Serhiy Storchaka in branch '3.4':
Issue
Serhiy Storchaka added the comment:
Thank you for your patch Martin.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
Berker Peksag added the comment:
In 3.4, namereplace_errors needs to be removed in the test:
https://hg.python.org/cpython/rev/2b642f2ca391#l2.17
==
FAIL: test_all (test.test_codecs.CodecsModuleTest)
Roundup Robot added the comment:
New changeset 1ab04bcd03bf by Serhiy Storchaka in branch '3.4':
Issue #23071: namereplace_errors was added only in 3.5.
https://hg.python.org/cpython/rev/1ab04bcd03bf
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Hmm, I have no ideas how I missed this when ran tests. Thank you Berker.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
___
Serhiy Storchaka added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
___
___
Python-bugs-list mailing list
Marc-Andre Lemburg added the comment:
+1
--
nosy: +lemburg
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
___
___
Python-bugs-list mailing
Martin Panter added the comment:
Here is the patch (against the default branch)
--
keywords: +patch
Added file: http://bugs.python.org/file37486/codecs-all.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
Berker Peksag added the comment:
Thanks! Could you also add a test? See PublicAPITests in
Lib/test/test_shutil.py as an example.
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
Martin Panter added the comment:
This patch includes a new test; although this kind of testing won’t detect when
someone adds a new API and forgets to add it to __all__.
--
Added file: http://bugs.python.org/file37491/codecs-all.patch
___
Python
New submission from Martin Panter:
First ones I noticed were codecs.encode() and codecs.decode(). Here is a list
of other candidates, although they are not all documented, so maybe should not
all be in __all__.
import codecs
public = (a for a in dir(codecs) if not a.startswith(_))
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
___
___
Serhiy Storchaka added the comment:
Yes, only documented names should be in __all__. Do you want to provide a patch
Martin? Suggestion: first filter names which are contained in codecs.rst.
--
keywords: +easy
nosy: +serhiy.storchaka
stage: - needs patch
versions: +Python 2.7, Python
Martin Panter added the comment:
Okay I will try and make a patch for this once I have finished a patch to
revise the documentation for Issue 19548
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23071
15 matches
Mail list logo
