Roundup Robot added the comment:
New changeset 7f30206d402f by Victor Stinner in branch '2.7':
Issue #23168: skip sys.stdin.seek() test if stdin is not a TTY
https://hg.python.org/cpython/rev/7f30206d402f
--
nosy: +python-dev
___
Python tracker
STINNER Victor added the comment:
Instead of removing the test, I modified it to be skipped if stdin is not a TTY.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23168
New submission from Dmitrijs Ledkovs:
# LD_LIBRARY_PATH=`pwd` ./python Lib/test/regrtest.py test_file2k /dev/null
[1/1] test_file2k
test test_file2k failed -- Traceback (most recent call last):
File /builddir/build/BUILD/Python-2.7.9/Lib/test/test_file2k.py, line 236,
in testStdin
Changes by Dmitrijs Ledkovs x...@ubuntu.com:
--
components: +Installation
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23168
___
Changes by Dmitrijs Ledkovs x...@ubuntu.com:
--
keywords: +patch
Added file: http://bugs.python.org/file37603/issue23168.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23168
___
Dimitri John Ledkov added the comment:
Removing a test when it doesn't pass is not the correct way to fix a test...
Whilst I agree, this is not what was done in http://bugs.python.org/issue14853
. There it was concluded that the test itself is bogus and tests essentially
nothing.
--
STINNER Victor added the comment:
Removing a test when it doesn't pass is not the correct way to fix a test...
I would be better to write it differently to support seekable stdin. Or if it
doesn't make sense, skip the test if stdin is seeable.
--
nosy: +haypo
